linux-kernel - Re: [PATCH v2] selftests: firmware: Add details in error logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aH0zxwC8eJ2GhcXu@harshPC>
Date: Sun, 20 Jul 2025 23:51:59 +0530
From: Harshal Wadhwa <embedkari167@...il.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: shuah@...nel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests: firmware: Add details in error logging

On Mon, Jul 14, 2025 at 03:39:47PM -0600, Shuah Khan wrote:
> On 7/14/25 15:26, Harshal wrote:
> > Specify details in logs of failed cases
> 
> How about changing the above to:
> 
> Improve error messages adding details on failuires
Will change this in next patch

> >   	fd = open(sys_path, O_WRONLY);
> >   	if (fd < 0)
> > -		die("open failed: %s\n",
> > +		die("open of sys_path failed: %s\n",
> 
> Why not just use sys_path as a input parameter to die()?
Sure, that's great. Is there a way to test these changes ?

> > @@ -129,8 +129,8 @@ int main(int argc, char **argv)
> >   		die("error: failed to build full fw_path\n");
> >   	setup_fw(fw_path);
> > -
> 
> Why did you remove this line?
> 
Will remove this change.
> >   	setvbuf(stdout, NULL, _IONBF, 0);
> > +
> 
> Why is this line added
This too.

Thanks,
Harshal