linux-kernel - Re: [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power domain indices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <q2zrfllvtvnrzfxie5oswe5epthvdadvz3ki3n3gb6thbn7vek@ef6ble5vbfbm>
Date: Sat, 19 Jul 2025 22:28:15 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Ling Xu <quic_lxu5@...cinc.com>, 
	Dmitry Baryshkov <lumag@...nel.org>, Tengfei Fan <quic_tengfan@...cinc.com>, 
	Jagadeesh Kona <quic_jkona@...cinc.com>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v2 1/4] arm64: dts: qcom: sa8775p: fix RPMh power domain
 indices

On Fri, Jul 18, 2025 at 06:25:38PM +0300, Dmitry Baryshkov wrote:
> On SA8775P power domains device doesn't use unufied (RPMHPD_foo) ABI,

"unified"

> but it uses SoC-specific indices (SA8775P_foo). Consequently, all DSP on
> that platform are referencing random PDs instead of the expected ones.
> 
> Correct indices used for that platform.
> 

Reviewed-by: Bjorn Andersson <andersson@...nel.org>

Regards,
Bjorn

> Fixes: df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes")
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 25 ++++++++++++-------------
>  1 file changed, 12 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9997a29901f57d7894dc1eacb6a809caa427c6c4..214e2c0e74ef53e8bc57acb8ee88901ef1006298 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -17,7 +17,6 @@
>  #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h>
>  #include <dt-bindings/mailbox/qcom-ipcc.h>
>  #include <dt-bindings/firmware/qcom,scm.h>
> -#include <dt-bindings/power/qcom,rpmhpd.h>
>  #include <dt-bindings/power/qcom-rpmpd.h>
>  #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>  
> @@ -6055,8 +6054,8 @@ remoteproc_gpdsp0: remoteproc@...00000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd RPMHPD_CX>,
> -					<&rpmhpd RPMHPD_MXC>;
> +			power-domains = <&rpmhpd SA8775P_CX>,
> +					<&rpmhpd SA8775P_MXC>;
>  			power-domain-names = "cx", "mxc";
>  
>  			interconnects = <&gpdsp_anoc MASTER_DSP0 0
> @@ -6098,8 +6097,8 @@ remoteproc_gpdsp1: remoteproc@...00000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd RPMHPD_CX>,
> -					<&rpmhpd RPMHPD_MXC>;
> +			power-domains = <&rpmhpd SA8775P_CX>,
> +					<&rpmhpd SA8775P_MXC>;
>  			power-domain-names = "cx", "mxc";
>  
>  			interconnects = <&gpdsp_anoc MASTER_DSP1 0
> @@ -6239,9 +6238,9 @@ remoteproc_cdsp0: remoteproc@...00000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd RPMHPD_CX>,
> -					<&rpmhpd RPMHPD_MXC>,
> -					<&rpmhpd RPMHPD_NSP0>;
> +			power-domains = <&rpmhpd SA8775P_CX>,
> +					<&rpmhpd SA8775P_MXC>,
> +					<&rpmhpd SA8775P_NSP0>;
>  			power-domain-names = "cx", "mxc", "nsp";
>  
>  			interconnects = <&nspa_noc MASTER_CDSP_PROC 0
> @@ -6371,9 +6370,9 @@ remoteproc_cdsp1: remoteproc@...00000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd RPMHPD_CX>,
> -					<&rpmhpd RPMHPD_MXC>,
> -					<&rpmhpd RPMHPD_NSP1>;
> +			power-domains = <&rpmhpd SA8775P_CX>,
> +					<&rpmhpd SA8775P_MXC>,
> +					<&rpmhpd SA8775P_NSP1>;
>  			power-domain-names = "cx", "mxc", "nsp";
>  
>  			interconnects = <&nspb_noc MASTER_CDSP_PROC_B 0
> @@ -6527,8 +6526,8 @@ remoteproc_adsp: remoteproc@...00000 {
>  			clocks = <&rpmhcc RPMH_CXO_CLK>;
>  			clock-names = "xo";
>  
> -			power-domains = <&rpmhpd RPMHPD_LCX>,
> -					<&rpmhpd RPMHPD_LMX>;
> +			power-domains = <&rpmhpd SA8775P_LCX>,
> +					<&rpmhpd SA8775P_LMX>;
>  			power-domain-names = "lcx", "lmx";
>  
>  			interconnects = <&lpass_ag_noc MASTER_LPASS_PROC 0 &mc_virt SLAVE_EBI1 0>;
> 
> -- 
> 2.39.5
>