linux-kernel - Re: [PATCH v5 2/4] dt-bindings: PCI: qcom,pcie-sa8775p: document link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <175305498292.3083407.12105009386525845667.robh@kernel.org>
Date: Sun, 20 Jul 2025 18:43:03 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Ziyue Zhang <ziyue.zhang@....qualcomm.com>
Cc: conor+dt@...nel.org, quic_krichai@...cinc.com, vkoul@...nel.org,
	bhelgaas@...gle.com, lpieralisi@...nel.org, krzk+dt@...nel.org,
	jingoohan1@...il.com, qiang.yu@....qualcomm.com,
	abel.vesa@...aro.org, linux-arm-msm@...r.kernel.org, kw@...ux.com,
	neil.armstrong@...aro.org, mani@...nel.org,
	devicetree@...r.kernel.org, johan+linaro@...nel.org,
	andersson@...nel.org, linux-pci@...r.kernel.org,
	kwilczynski@...nel.org, linux-kernel@...r.kernel.org,
	quic_vbadigan@...cinc.com, kishon@...nel.org,
	konradybcio@...nel.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v5 2/4] dt-bindings: PCI: qcom,pcie-sa8775p: document
 link_down reset


On Fri, 18 Jul 2025 16:17:16 +0800, Ziyue Zhang wrote:
> Each PCIe controller on SA8775P includes a 'link_down' reset line in
> hardware. This patch documents the reset in the device tree binding.
> 
> The 'link_down' reset is used to forcefully bring down the PCIe link
> layer, which is useful in scenarios such as link recovery after errors,
> power management transitions, and hotplug events. Including this reset
> line improves robustness and provides finer control over PCIe controller
> behavior.
> 
> As the 'link_down' reset was omitted in the initial submission, it is now
> being documented. While this reset is not required for most of the block's
> basic functionality, and device trees lacking it will continue to function
> correctly in most cases, it is necessary to ensure maximum robustness when
> shutting down or recovering the PCIe core. Therefore, its inclusion is
> justified despite the minor ABI change.
> 
> Signed-off-by: Ziyue Zhang <ziyue.zhang@....qualcomm.com>
> ---
>  .../devicetree/bindings/pci/qcom,pcie-sa8775p.yaml    | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>