linux-kernel - Re: [PATCH] staging: rtl8723bs: Improve indentation consistency in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025072044-program-certified-8112@gregkh>
Date: Sun, 20 Jul 2025 08:42:27 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Vivek BalachandharTN <vivek.balachandhar@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Improve indentation consistency in
 rtw_mlme.c

On Sat, Jul 19, 2025 at 11:07:07PM +0000, Vivek BalachandharTN wrote:
> This patch cleans up inconsistent indentation in rtw_mlme.c to improve code
> readability and align with kernel coding style.

Ok, but:

> @@ -119,7 +123,7 @@ struct	wlan_network *rtw_alloc_network(struct	mlme_priv *pmlmepriv)
>  		pnetwork = NULL;
>  		goto exit;
>  	}
> -	plist = get_next(&(free_queue->queue));
> +	plist = get_next(&free_queue->queue);

That is not an indentation issue.

> @@ -141,7 +145,7 @@ void _rtw_free_network(struct	mlme_priv *pmlmepriv, struct wlan_network *pnetwor
>  {
>  	unsigned int delta_time;
>  	u32 lifetime = SCANQUEUE_LIFETIME;
> -	struct __queue *free_queue = &(pmlmepriv->free_bss_pool);
> +	struct __queue *free_queue = &pmlmepriv->free_bss_pool;

Nor was that.

I stopped reviewing here, sorry.

Please only do one type of thing per patch.

thanks,

greg k-h