linux-kernel - Re: 回复: [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87qzy9tvso.ffs@tglx>
Date: Mon, 21 Jul 2025 17:20:39 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: panchuang <panchuang@...o.com>, Miquel Raynal <miquel.raynal@...tlin.com>
Cc: 李扬韬 <frank.li@...o.com>, Uwe Kleine-König
 <u.kleine-koenig@...gutronix.de>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui
 <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, Markus Mayer
 <mmayer@...adcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Shawn Guo <shawnguo@...nel.org>, Sascha
 Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, zhanghongchen
 <zhanghongchen@...ngson.cn>, Yinbo Zhu <zhuyinbo@...ngson.cn>, Amit
 Kucheria <amitk@...nel.org>, Thara Gopinath <thara.gopinath@...il.com>,
 Niklas Söderlund <niklas.soderlund@...natech.se>, Geert
 Uytterhoeven <geert+renesas@...der.be>, Magnus Damm
 <magnus.damm@...il.com>, Heiko Stuebner <heiko@...ech.de>, Bartlomiej
 Zolnierkiewicz <bzolnier@...il.com>, Krzysztof Kozlowski <krzk@...nel.org>,
 Alim Akhtar <alim.akhtar@...sung.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Vasily Khoruzhick <anarsoul@...il.com>,
 Yangtao Li <tiny.windzz@...il.com>, Chen-Yu Tsai <wens@...e.org>, Jernej
 Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
 Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter
 <jonathanh@...dia.com>, Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
 Masami Hiramatsu <mhiramat@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Srinivas Pandruvada
 <srinivas.pandruvada@...ux.intel.com>, Greg KH
 <gregkh@...uxfoundation.org>, Peter Zijlstra <peterz@...radead.org>,
 Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Conor Dooley
 <conor.dooley@...rochip.com>, Julien Panis <jpanis@...libre.com>, Arnd
 Bergmann <arnd@...db.de>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>,
 Colin Ian King <colin.i.king@...il.com>, Raphael Gallais-Pou
 <rgallaispou@...il.com>, Patrice Chotard <patrice.chotard@...s.st.com>,
 Jonathan Cameron <jonathan.cameron@...wei.com>, "Jiri Slaby (SUSE)"
 <jirislaby@...nel.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Andrew Morton <akpm@...ux-foundation.org>, Costa Shulyupin
 <costa.shul@...hat.com>, Yury
 Norov <yury.norov@...il.com>, Cheng-Yang Chou <yphbchou0911@...il.com>,
 Caleb Sander Mateos <csander@...estorage.com>, "linux-pm@...r.kernel.org"
 <linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
 <imx@...ts.linux.dev>, "linux-arm-msm@...r.kernel.org"
 <linux-arm-msm@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
 <linux-renesas-soc@...r.kernel.org>, "linux-rockchip@...ts.infradead.org"
 <linux-rockchip@...ts.infradead.org>, "linux-samsung-soc@...r.kernel.org"
 <linux-samsung-soc@...r.kernel.org>,
 "linux-stm32@...md-mailman.stormreply.com"
 <linux-stm32@...md-mailman.stormreply.com>, "linux-sunxi@...ts.linux.dev"
 <linux-sunxi@...ts.linux.dev>, "linux-tegra@...r.kernel.org"
 <linux-tegra@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
 <linux-mediatek@...ts.infradead.org>
Subject: Re: 回复: [PATCH v6 01/24] genirq/devres: Add
 devm_request_threaded_irq_probe() and devm_request_irq_probe()

On Sat, Jul 19 2025 at 23:08, Thomas Gleixner wrote:
> On Wed, Jul 09 2025 at 17:13, panchuang@...o.com wrote:
>> Hi tglx and Miquèl, Just a gentle ping on this patchset. I understand 
>> you're likely busy with many other tasks, but any feedback or guidance 
>> on how to proceed would be greatly appreciated. As discussed in the 
>> previous thread, there was some uncertainty about whether we should 
>> directly integrate dev_err_probe() into devm_request_threaded_irq(), or 
>> if it's better to create a wrapper function. Thanks for your time! 
>> Thanks, Panchuang

For simplicity sake just rename the existing functions
devm_request_threaded_irq() and devm_request_any_context_irq() to
__devm_request_threaded_irq() and __devm_request_any_context_irq().

Then create new functions for the API, which

   - invoke the underscore variants
   - and on error invoke dev_err_probe() similar to what I suggested in
     my reply in this thread.

In the rare case of failure, this will print error messages for the
affected drivers both in the core and at the callsite, but that's not
the end of the world.

Then go and remove the random printks from the drivers, once the core
change has hit upstream.

Thanks,

        tglx