linux-kernel - Re: [PATCH v2 4/5] net: cadence: macb: sama7g5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <848529cc-0d01-4012-ae87-8a98b1307cbe@microchip.com>
Date: Mon, 21 Jul 2025 15:39:02 +0000
From: <Ryan.Wanner@...rochip.com>
To: <claudiu.beznea@...on.dev>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <Nicolas.Ferre@...rochip.com>,
	<alexandre.belloni@...tlin.com>
CC: <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 4/5] net: cadence: macb: sama7g5_emac: Remove USARIO
 CLKEN flag

On 7/18/25 04:00, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi, Ryan,
> 
> On 14.07.2025 19:37, Ryan.Wanner@...rochip.com wrote:
>> From: Ryan Wanner <Ryan.Wanner@...rochip.com>
>>
>> Remove USARIO_CLKEN flag since this is now a device tree argument and
> 
> s/USARIO_CLKEN/USRIO_HAS_CLKEN here and in title as well.
> 
>> not fixed to the SoC.
>>
>> This will instead be selected by the "cdns,refclk-ext"
>> device tree property.
>>
>> Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>
>> ---
>>  drivers/net/ethernet/cadence/macb_main.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
>> index 51667263c01d..cd54e4065690 100644
>> --- a/drivers/net/ethernet/cadence/macb_main.c
>> +++ b/drivers/net/ethernet/cadence/macb_main.c
>> @@ -5113,8 +5113,7 @@ static const struct macb_config sama7g5_gem_config = {
>>
>>  static const struct macb_config sama7g5_emac_config = {
>>       .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII |
>> -             MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_MIIONRGMII |
> 
> Will old DTBs still work with new kernels with this change?

That was my assumption, but it seems it would be safer to keep this
property for this IP and implement this dt flag property on IPs that do
not already have  MACB_CAPS_USRIO_HAS_CLKEN property.

Ryan
> 
> Thank you,
> Claudiu
> 
>> -             MACB_CAPS_GEM_HAS_PTP,
>> +             MACB_CAPS_MIIONRGMII | MACB_CAPS_GEM_HAS_PTP,
>>       .dma_burst_length = 16,
>>       .clk_init = macb_clk_init,
>>       .init = macb_init,
>