linux-kernel - Re: [PATCH v2 1/3] arm64: dts: imx8mm-evk: support more sample rates for wm8524 card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aH5iI0qR7eW6Yg7Z@lizhi-Precision-Tower-5810>
Date: Mon, 21 Jul 2025 11:52:03 -0400
From: Frank Li <Frank.li@....com>
To: Shengjiu Wang <shengjiu.wang@....com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
	festevam@...il.com, devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	shengjiu.wang@...il.com
Subject: Re: [PATCH v2 1/3] arm64: dts: imx8mm-evk: support more sample rates
 for wm8524 card

On Mon, Jul 21, 2025 at 04:34:31PM +0800, Shengjiu Wang wrote:
> The wm8524 codec is connected to the SAI interface. There are two audio
> plls on i.MX8MM, one pll can be the clock source of 44kHz series rates,
> another pll can be clock source of 48kHz series rates.
>
> Previously it only supported 48kHz series rates, with this change the
> supported rates will include 44kHz series rates, from 8kHz to 192kHz.
>
> As commit 17cc308b1833 ("ASoC: wm8524: enable constraints when sysclk is
> configured.") make wm8524 release the constraint when codec's sysclk is
> not configured, so we can configure the cpu dai's sysclk to support more
> rates with the 'clocks' property removed.

nit: remove 'we can'

>
> Add mclk-fs property for the sysclk ratio, which is required by
> calculating the sysclk, 256 is a common ratio for audio.
>
> 'system-clock-direction-out' is a must have property after

nit" 'must have' to 'required'

> commit 5725bce709db ("ASoC: simple-card-utils: Unify clock direction by
> clk_direction") to specify the clock direction.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> ---

Reviewed-by: Frank Li <Frank.Li@....com>

>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index 622caaa78eaf..ff7ca2075230 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -147,6 +147,7 @@ sound-wm8524 {
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,frame-master = <&cpudai>;
>  		simple-audio-card,bitclock-master = <&cpudai>;
> +		simple-audio-card,mclk-fs = <256>;
>  		simple-audio-card,widgets =
>  			"Line", "Left Line Out Jack",
>  			"Line", "Right Line Out Jack";
> @@ -158,11 +159,11 @@ cpudai: simple-audio-card,cpu {
>  			sound-dai = <&sai3>;
>  			dai-tdm-slot-num = <2>;
>  			dai-tdm-slot-width = <32>;
> +			system-clock-direction-out;
>  		};
>
>  		simple-audio-card,codec {
>  			sound-dai = <&wm8524>;
> -			clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
>  		};
>  	};
>
> @@ -570,9 +571,17 @@ &sai2 {
>  &sai3 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_sai3>;
> -	assigned-clocks = <&clk IMX8MM_CLK_SAI3>;
> -	assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
> -	assigned-clock-rates = <24576000>;
> +	assigned-clocks = <&clk IMX8MM_AUDIO_PLL1>,
> +			  <&clk IMX8MM_AUDIO_PLL2>,
> +			  <&clk IMX8MM_CLK_SAI3>;
> +	assigned-clock-parents = <0>, <0>, <&clk IMX8MM_AUDIO_PLL1_OUT>;
> +	assigned-clock-rates = <393216000>, <361267200>, <24576000>;
> +	fsl,sai-mclk-direction-output;
> +	clocks = <&clk IMX8MM_CLK_SAI3_IPG>, <&clk IMX8MM_CLK_DUMMY>,
> +		<&clk IMX8MM_CLK_SAI3_ROOT>, <&clk IMX8MM_CLK_DUMMY>,
> +		<&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_AUDIO_PLL1_OUT>,
> +		<&clk IMX8MM_AUDIO_PLL2_OUT>;
> +	clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3", "pll8k", "pll11k";
>  	status = "okay";
>  };
>
> --
> 2.34.1
>