linux-kernel - Re: [PATCH v2] gpio-mlxbf2: only get IRQ for device instances 0 and 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025072158-backpedal-immortal-9dfe@gregkh>
Date: Mon, 21 Jul 2025 18:01:09 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: David Thompson <davthompson@...dia.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, davem@...emloft.net,
	asmaa@...dia.com, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Shravan Kumar Ramani <shravankr@...dia.com>
Subject: Re: [PATCH v2] gpio-mlxbf2: only get IRQ for device instances 0 and 3

On Mon, Jul 21, 2025 at 11:55:13AM -0400, David Thompson wrote:
> The gpio-mlxbf2 driver interfaces with four GPIO controllers,
> device instances 0-3. There are two IRQ resources shared between
> the four controllers, and they are found in the ACPI table for
> device instances 0 and 3.  The driver should not attempt to get
> an IRQ resource when probing device instance 1 or 2, otherwise
> the following error is logged:
>   mlxbf2_gpio MLNXBF22:01: error -ENXIO: IRQ index 0 not found
> 
> Fixes: 2b725265cb08 ("gpio: mlxbf2: Introduce IRQ support")
> Cc: stable@...r.kernel.org
> Signed-off-by: David Thompson <davthompson@...dia.com>
> Reviewed-by: Shravan Kumar Ramani <shravankr@...dia.com>
> ---
>  drivers/gpio/gpio-mlxbf2.c | 56 ++++++++++++++++++++++++--------------
>  1 file changed, 36 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
> index 6f3dda6b635f..fc56ac81e344 100644
> --- a/drivers/gpio/gpio-mlxbf2.c
> +++ b/drivers/gpio/gpio-mlxbf2.c
> @@ -353,7 +353,9 @@ mlxbf2_gpio_probe(struct platform_device *pdev)
>  	struct gpio_chip *gc;
>  	unsigned int npins;
>  	const char *name;
> +	char *colon_ptr;
>  	int ret, irq;
> +	long num;
>  
>  	name = dev_name(dev);
>  
> @@ -397,26 +399,40 @@ mlxbf2_gpio_probe(struct platform_device *pdev)
>  	gc->ngpio = npins;
>  	gc->owner = THIS_MODULE;
>  
> -	irq = platform_get_irq(pdev, 0);
> -	if (irq >= 0) {
> -		girq = &gs->gc.irq;
> -		gpio_irq_chip_set_chip(girq, &mlxbf2_gpio_irq_chip);
> -		girq->handler = handle_simple_irq;
> -		girq->default_type = IRQ_TYPE_NONE;
> -		/* This will let us handle the parent IRQ in the driver */
> -		girq->num_parents = 0;
> -		girq->parents = NULL;
> -		girq->parent_handler = NULL;
> -
> -		/*
> -		 * Directly request the irq here instead of passing
> -		 * a flow-handler because the irq is shared.
> -		 */
> -		ret = devm_request_irq(dev, irq, mlxbf2_gpio_irq_handler,
> -				       IRQF_SHARED, name, gs);
> -		if (ret) {
> -			dev_err(dev, "failed to request IRQ");
> -			return ret;
> +	colon_ptr = strchr(dev_name(dev), ':');
> +	if (!colon_ptr) {
> +		dev_err(dev, "invalid device name format\n");
> +		return -EINVAL;
> +	}
> +
> +	ret = kstrtol(++colon_ptr, 16, &num);
> +	if (ret) {
> +		dev_err(dev, "invalid device instance\n");
> +		return ret;
> +	}
> +
> +	if (!num || num == 3) {
> +		irq = platform_get_irq(pdev, 0);
> +		if (irq >= 0) {
> +			girq = &gs->gc.irq;
> +			gpio_irq_chip_set_chip(girq, &mlxbf2_gpio_irq_chip);
> +			girq->handler = handle_simple_irq;
> +			girq->default_type = IRQ_TYPE_NONE;
> +			/* This will let us handle the parent IRQ in the driver */
> +			girq->num_parents = 0;
> +			girq->parents = NULL;
> +			girq->parent_handler = NULL;
> +
> +			/*
> +			 * Directly request the irq here instead of passing
> +			 * a flow-handler because the irq is shared.
> +			 */
> +			ret = devm_request_irq(dev, irq, mlxbf2_gpio_irq_handler,
> +					       IRQF_SHARED, name, gs);
> +			if (ret) {
> +				dev_err(dev, "failed to request IRQ");
> +				return ret;
> +			}
>  		}
>  	}
>  
> -- 
> 2.30.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot