linux-kernel - Re: [PATCH v4 0/6] binder: Set up KUnit tests for alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <699122f8-e6c4-4c0d-ab2f-3e1de2c8921e@nvidia.com>
Date: Mon, 21 Jul 2025 12:22:09 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: Tiffany Yang <ynaffit@...gle.com>, linux-kernel@...r.kernel.org
Cc: keescook@...gle.com, kernel-team@...roid.com,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Arve Hjønnevåg <arve@...roid.com>,
 Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
 Christian Brauner <brauner@...nel.org>, Carlos Llamas <cmllamas@...gle.com>,
 Suren Baghdasaryan <surenb@...gle.com>,
 Brendan Higgins <brendan.higgins@...ux.dev>, David Gow
 <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>,
 linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com
Subject: Re: [PATCH v4 0/6] binder: Set up KUnit tests for alloc



On 7/16/2025 9:10 PM, Tiffany Yang wrote:
> Hello,
> 
> binder_alloc_selftest provides a robust set of checks for the binder
> allocator, but it rarely runs because it must hook into a running binder
> process and block all other binder threads until it completes. The test
> itself is a good candidate for conversion to KUnit, and it can be
> further isolated from user processes by using a test-specific lru
> freelist instead of the global one. This series converts the selftest
> to KUnit to make it less burdensome to run and to set up a foundation
> for unit testing future binder_alloc changes.
> 
> Thanks,
> Tiffany
> 
> Tiffany Yang (6):
>   binder: Fix selftest page indexing
>   binder: Store lru freelist in binder_alloc
>   kunit: test: Export kunit_attach_mm()
>   binder: Scaffolding for binder_alloc KUnit tests
>   binder: Convert binder_alloc selftests to KUnit
>   binder: encapsulate individual alloc test cases


Looks good to me!  And I learnt a bunch of kunit from reading this too. :)

Reviewed-by: Joel Fernandes <joelagnelf@...dia.com>

 - Joel