linux-kernel - Re: [PATCH] selftests/futex: Compile also on libnuma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h5z5tq51.ffs@tglx>
Date: Mon, 21 Jul 2025 19:22:50 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>, kernel test robot
 <oliver.sang@...el.com>
Cc: oe-lkp@...ts.linux.dev, lkp@...el.com, linux-kernel@...r.kernel.org,
 Peter Zijlstra <peterz@...radead.org>, Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH] selftests/futex: Compile also on libnuma < 2.0.16

On Tue, Jul 15 2025 at 11:52, Sebastian Andrzej Siewior wrote:
>  INCLUDES := -I../include -I../../ $(KHDR_INCLUDES)
> -CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES)
> +CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES) -DLIBUNMA_VER_$(LIBNUMA_TEST)=1

LIBUNMA?

>  int main(int argc, char *argv[])
>  {
>  	struct futex32_numa *futex_numa;
> -	int mem_size, i;
> +	int mem_size, i __maybe_unused;

Why this unused muck?

> +#ifdef LIBUNMA_VER_SUFFICIENT
>  	for (i = 0; i < 4; i++) {

if you can just do

       for (int i = 0; ...

?

Thanks,

        tglx