linux-kernel - Re: [PATCH] usb: core: add urb->sgt parameter description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53b1a47d-2338-44f3-8d78-8c4b02e0fa81@infradead.org>
Date: Mon, 21 Jul 2025 11:13:14 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Xu Yang <xu.yang_2@....com>, gregkh@...uxfoundation.org,
 sfr@...b.auug.org.au
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-next@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH] usb: core: add urb->sgt parameter description



On 7/21/25 3:44 AM, Xu Yang wrote:
> The parameter description of urb->sgt is lost, this will add it for
> completeness.
> 
> Reported-by: Stephen Rothwell<sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/all/20250711182803.1d548467@canb.auug.org.au/
> Signed-off-by: Xu Yang <xu.yang_2@....com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  include/linux/usb.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index 535ac37198a1..9d662c6abb4d 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -1455,6 +1455,10 @@ typedef void (*usb_complete_t)(struct urb *);
>   * @sg: scatter gather buffer list, the buffer size of each element in
>   * 	the list (except the last) must be divisible by the endpoint's
>   * 	max packet size if no_sg_constraint isn't set in 'struct usb_bus'
> + * @sgt: used to hold a scatter gather table returned by usb_alloc_noncoherent(),
> + *      which describes the allocated non-coherent and possibly non-contiguous
> + *      memory and is guaranteed to have 1 single DMA mapped segment. The
> + *      allocated memory needs to be freed by usb_free_noncoherent().
>   * @num_mapped_sgs: (internal) number of mapped sg entries
>   * @num_sgs: number of entries in the sg list
>   * @transfer_buffer_length: How big is transfer_buffer.  The transfer may

-- 
~Randy