linux-kernel - Re: [PATCH] wifi: brcmfmac: cyw: Fix __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54478268-48d1-4163-9bcb-d576cc93f7ce@embeddedor.com>
Date: Mon, 21 Jul 2025 13:03:23 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Kees Cook <kees@...nel.org>, Johannes Berg <johannes.berg@...el.com>
Cc: Chung-Hsien Hsu <chung-hsien.hsu@...ineon.com>,
 Chi-hsien Lin <chi-hsien.lin@...ineon.com>,
 James Prestwood <prestwoj@...il.com>,
 Arend van Spriel <arend.vanspriel@...adcom.com>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Ting-Ying Li <tingying.li@...ress.com>, linux-wireless@...r.kernel.org,
 brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com,
 linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: cyw: Fix __counted_by to be LE variant



On 21/07/25 12:18, Kees Cook wrote:
> In brcmf_cyw_mgmt_tx() the "len" counter of the struct
> brcmf_mf_params_le::data flexible array is stored as little-endian via
> cpu_to_le16() so the __counted_by_le() variant must be used:
> 
> 	struct brcmf_mf_params_le *mf_params;
> 	...
> 	mf_params_len = offsetof(struct brcmf_mf_params_le, data) +
> 			(len - DOT11_MGMT_HDR_LEN);
> 	mf_params = kzalloc(mf_params_len, GFP_KERNEL);
> 	...
>          mf_params->len = cpu_to_le16(len - DOT11_MGMT_HDR_LEN);
> 
> Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode")
> Signed-off-by: Kees Cook <kees@...nel.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks!
-Gustavo

> ---
> Cc: Johannes Berg <johannes.berg@...el.com>
> Cc: Chung-Hsien Hsu <chung-hsien.hsu@...ineon.com>
> Cc: Chi-hsien Lin <chi-hsien.lin@...ineon.com>
> Cc: James Prestwood <prestwoj@...il.com>
> Cc: Arend van Spriel <arend.vanspriel@...adcom.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Cc: Ting-Ying Li <tingying.li@...ress.com>
> Cc: <linux-wireless@...r.kernel.org>
> Cc: <brcm80211@...ts.linux.dev>
> Cc: <brcm80211-dev-list.pdl@...adcom.com>
> Cc: <linux-hardening@...r.kernel.org>
> ---
>   .../net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h   | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
> index 08c69142495a..669564382e32 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
> @@ -80,7 +80,7 @@ struct brcmf_mf_params_le {
>   	u8 da[ETH_ALEN];
>   	u8 bssid[ETH_ALEN];
>   	__le32 packet_id;
> -	u8 data[] __counted_by(len);
> +	u8 data[] __counted_by_le(len);
>   };
>   
>   #endif /* CYW_FWIL_TYPES_H_ */