linux-kernel - Re: [PATCH v15 19/34] fs/resctrl: Pass struct rdtgroup instead of individual members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e925211-a988-4317-9879-f0c47800f80f@amd.com>
Date: Mon, 21 Jul 2025 15:59:11 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 tony.luck@...el.com, james.morse@....com, tglx@...utronix.de,
 mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com
Cc: Dave.Martin@....com, x86@...nel.org, hpa@...or.com,
 akpm@...ux-foundation.org, paulmck@...nel.org, rostedt@...dmis.org,
 Neeraj.Upadhyay@....com, david@...hat.com, arnd@...db.de, fvdl@...gle.com,
 seanjc@...gle.com, jpoimboe@...nel.org, pawan.kumar.gupta@...ux.intel.com,
 xin@...or.com, manali.shukla@....com, tao1.su@...ux.intel.com,
 sohil.mehta@...el.com, kai.huang@...el.com, xiaoyao.li@...el.com,
 peterz@...radead.org, xin3.li@...el.com, kan.liang@...ux.intel.com,
 mario.limonciello@....com, thomas.lendacky@....com, perry.yuan@....com,
 gautham.shenoy@....com, chang.seok.bae@...el.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, peternewman@...gle.com, eranian@...gle.com
Subject: Re: [PATCH v15 19/34] fs/resctrl: Pass struct rdtgroup instead of
 individual members

Hi Reinette,

On 7/17/25 22:54, Reinette Chatre wrote:
> Hi Babu,
> 
> On 7/8/25 3:17 PM, Babu Moger wrote:
>> Reading monitoring data for a monitoring group requires both the RMID and
>> CLOSID. The RMID and CLOSID are members of struct rdtgroup but passed
>> separately to several functions involved in retrieving event data.
>>
>> When "mbm_event" counter assignment mode is enabled, a counter ID is
>> required to read event data. The counter ID is obtained through
>> mbm_cntr_get(), which expects a struct rdtgroup pointer.
>>
>> Provide a pointer to the struct rdtgroup as parameter to functions involved
>> in retrieving event data to simplify access to RMID, CLOSID, and counter
>> ID.
>>
>> Suggested-by: Reinette Chatre <reinette.chatre@...el.com>
>> Signed-off-by: Babu Moger <babu.moger@....com>
>> ---
> 
> ...
> 
>> @@ -429,9 +431,11 @@ static int __mon_event_count(u32 closid, u32 rmid, struct rmid_read *rr)
>>   * __mon_event_count() is compared with the chunks value from the previous
>>   * invocation. This must be called once per second to maintain values in MBps.
>>   */
>> -static void mbm_bw_count(u32 closid, u32 rmid, struct rmid_read *rr)
>> +static void mbm_bw_count(struct rdtgroup *rdtgrp, struct rmid_read *rr)
> 
> Function comments need an update to match this change.

Sure.

> 
>>  {
>>  	u64 cur_bw, bytes, cur_bytes;
>> +	u32 closid = rdtgrp->closid;
>> +	u32 rmid = rdtgrp->mon.rmid;
>>  	struct mbm_state *m;
>>  
>>  	m = get_mbm_state(rr->d, closid, rmid, rr->evtid);
> 
> Reinette
> 

-- 
Thanks
Babu Moger