linux-kernel - Re: linux-next: Tree for Jul 21 (fs/erofs/*.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b555f01c-4e9e-4b42-aa5a-2d35ef9c1c50@infradead.org>
Date: Mon, 21 Jul 2025 14:31:25 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>,
 Linux Next Mailing List <linux-next@...r.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 linux-fsdevel@...r.kernel.org, Gao Xiang <xiang@...nel.org>,
 Chao Yu <chao@...nel.org>, linux-erofs@...ts.ozlabs.org,
 Bo Liu <liubo03@...pur.com>
Subject: Re: linux-next: Tree for Jul 21 (fs/erofs/*.c)



On 7/21/25 12:41 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20250718:
> 

on i386 (i.e., 32-bit):

In file included from ../include/linux/bits.h:5,
                 from ../include/linux/string_helpers.h:5,
                 from ../include/linux/seq_file.h:7,
                 from ../fs/erofs/super.c:8:
../fs/erofs/internal.h: In function 'erofs_inode_in_metabox':
../include/vdso/bits.h:7:40: warning: left shift count >= width of type [-Wshift-count-overflow]
    7 | #define BIT(nr)                 (UL(1) << (nr))
      |                                        ^~
../fs/erofs/internal.h:305:38: note: in expansion of macro 'BIT'
  305 |         return EROFS_I(inode)->nid & BIT(EROFS_DIRENT_NID_METABOX_BIT);
      |                                      ^~~


Only super.c is shown here, but the warnings happen any time that the macro:
#define EROFS_DIRENT_NID_METABOX_BIT	63
is used (on 32-bit), all (or mostly) from internal.h erofs_nid_to_ino64():
	return ((nid << 1) & GENMASK_ULL(63, 32)) | (nid & GENMASK(30, 0)) |
		((nid >> EROFS_DIRENT_NID_METABOX_BIT) << 31);


-- 
~Randy