linux-kernel - Re: [PATCH v9 9/9] PCI: Add a new 'boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250721230013.GA2759370@bhelgaas>
Date: Mon, 21 Jul 2025 18:00:13 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Mario Limonciello <superm1@...nel.org>
Cc: David Airlie <airlied@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	Simona Vetter <simona@...ll.ch>, Lukas Wunner <lukas@...ner.de>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Woodhouse <dwmw2@...radead.org>,
	Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>,
	Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:INTEL IOMMU (VT-d)" <iommu@...ts.linux.dev>,
	"open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
	"open list:VFIO DRIVER" <kvm@...r.kernel.org>,
	"open list:SOUND" <linux-sound@...r.kernel.org>,
	Daniel Dadap <ddadap@...dia.com>,
	Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH v9 9/9] PCI: Add a new 'boot_display' attribute

On Fri, Jul 18, 2025 at 12:44:11PM -0500, Mario Limonciello wrote:
> On 7/18/2025 12:36 PM, Bjorn Helgaas wrote:
> > On Fri, Jul 18, 2025 at 12:29:05PM -0500, Mario Limonciello wrote:
> > > On 7/18/2025 12:25 PM, Bjorn Helgaas wrote:
> > > > On Thu, Jul 17, 2025 at 12:38:12PM -0500, Mario Limonciello wrote:
> > > > > From: Mario Limonciello <mario.limonciello@....com>
> > > > > 
> > > > > On systems with multiple GPUs there can be uncertainty which GPU is the
> > > > > primary one used to drive the display at bootup. In some desktop
> > > > > environments this can lead to increased power consumption because
> > > > > secondary GPUs may be used for rendering and never go to a low power
> > > > > state. In order to disambiguate this add a new sysfs attribute
> > > > > 'boot_display' that uses the output of video_is_primary_device() to
> > > > > populate whether a PCI device was used for driving the display.
> > > > 
> > > > > +What:		/sys/bus/pci/devices/.../boot_display
> > > > > +Date:		October 2025
> > > > > +Contact:	Linux PCI developers <linux-pci@...r.kernel.org>
> > > > > +Description:
> > > > > +		This file indicates that displays connected to the device were
> > > > > +		used to display the boot sequence.  If a display connected to
> > > > > +		the device was used to display the boot sequence the file will
> > > > > +		be present and contain "1".
> > > > 
> > > > >    int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)
> > > > >    {
> > > > > +	int retval;
> > > > > +
> > > > >    	if (!sysfs_initialized)
> > > > >    		return -EACCES;
> > > > > +	retval = pci_create_boot_display_file(pdev);
> > > > 
> > > > In addition to Mani's question about whether /sys/bus/pci/ is
> > > > the right place for this (which is a very good question), it's
> > > > also been pointed out to me that we've been trying to get rid
> > > > of pci_create_sysfs_dev_files() for years.
> > > > 
> > > > If it's possible to make this a static attribute that would be
> > > > much, much cleaner.
> > > 
> > > Right - I tried to do this, but the problem is at the time the
> > > PCI device is created the information needed to make the
> > > judgement isn't ready.  The options end up being:
> > > * a sysfs file for every display device with 0/1
> > > * a sysfs file that is not accurate until later in the boot
> > 
> > What's missing?  The specifics might be helpful if someone has
> > another crack at getting rid of pci_create_sysfs_dev_files() in
> > the future.
> 
> The underlying SCREEN_INFO code tries to walk through all the PCI
> devices in a loop, but at the time all the devices are walked the
> memory regions associated with the device weren't populated.

Which loop are you referring to that walks through all the PCI
devices?  I see this:

  efifb_set_system
    for_each_pci_dev(dev)

but that only looks at VGA devices and IIUC you also want to look at
non-VGA GPUs.

I don't see a loop in *this* series, where the screen_info path looks
like this:

  pci_create_boot_display_file
    video_is_primary_device
      screen_info_pci_dev      # added by "fbcon: Use screen info to find primary device"
        screen_info_resources
        __screen_info_pci_dev

and we're basically matching the screen_info base/address with BAR
values.

The usual problem is that BARs may not have been assigned by the time
pci_device_add() -> device_add() creates the static attributes.

So we call pci_assign_unassigned_root_bus_resources() to assign all
the BARs.  Then we call pci_create_sysfs_dev_files(), where
pci_create_resource_files() creates a "resource%d" file for each BAR.

But since we're trying to find the GPU that was used by BIOS, I assume
its BARs were programmed by BIOS and we shouldn't have to wait until
after pci_assign_unassigned_root_bus_resources().

Bjorn