linux-kernel - Re: [PATCH 00/16] Add support for the Axis ARTPEC-8 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8ab3efec0eac72e74cd7864c81c91cd796e3074.camel@coasia.com>
Date: Mon, 21 Jul 2025 13:32:17 +0900
From: Hakyeong Kim <hgkim05@...sia.com>
To: Linus Walleij <linus.walleij@...aro.org>, ksk4725@...sia.com
Cc: Jesper Nilsson <jesper.nilsson@...s.com>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, Sylwester
 Nawrocki <s.nawrocki@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>,
 Alim Akhtar <alim.akhtar@...sung.com>, Tomasz Figa <tomasz.figa@...il.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Arnd Bergmann <arnd@...db.de>, kenkim <kenkim@...sia.com>, Jongshin Park
 <pjsin865@...sia.com>,  GunWoo Kim <gwk1013@...sia.com>, GyoungBo Min
 <mingyoungbo@...sia.com>, SungMin Park <smn1196@...sia.com>,  Pankaj Dubey
 <pankaj.dubey@...sung.com>, Shradha Todi <shradha.t@...sung.com>, Ravi
 Patel <ravi.patel@...sung.com>, Inbaraj E <inbaraj.e@...sung.com>, Swathi K
 S <swathi.ks@...sung.com>, Hrishikesh <hrishikesh.d@...sung.com>, Dongjin
 Yang <dj76.yang@...sung.com>, Sang Min Kim <hypmean.kim@...sung.com>, 
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 linux-samsung-soc@...r.kernel.org, linux-arm-kernel@...s.com, 
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-gpio@...r.kernel.org, soc@...ts.linux.dev
Subject: Re: [PATCH 00/16] Add support for the Axis ARTPEC-8 SoC

On Sat, 2025-07-12 at 21:26 +0200, Linus Walleij wrote:
> Hi Hakyeong,
> 
> thanks for your patch!
> 
> On Thu, Jul 10, 2025 at 2:20 AM <ksk4725@...sia.com> wrote:
> 
> > Add basic support for the Axis ARTPEC-8 SoC.
> > This SoC contains four Cortex-A53 CPUs and other several IPs.
> > 
> > Patches 1 to 10 provide the support for the clock controller,
> > which is similar to other Samsung SoCs.
> > 
> > The remaining patches provide pinctrl support and
> > initial device tree support.
> > 
> > Hakyeong Kim (9):
> >   dt-bindings: clock: Add ARTPEC-8 CMU bindings
> >   clk: samsung: Add clock PLL support for ARTPEC-8 SoC
> >   clk: samsung: artpec-8: Add initial clock support
> >   clk: samsung: artpec-8: Add clock support for CMU_CMU block
> >   clk: samsung: artpec-8: Add clock support for CMU_BUS block
> >   clk: samsung: artpec-8: Add clock support for CMU_CORE block
> >   clk: samsung: artpec-8: Add clock support for CMU_CPUCL block
> >   clk: samsung: artpec-8: Add clock support for CMU_FSYS block
> >   clk: samsung: artpec-8: Add clock support for CMU_PERI block
> 
> Out of the 9 patches there are 7 patches related to "CMU" without
> any explanation or even expansion of this acronym.
> 
> Camera Management Unit? I think I'm not supposed to
> guess. Is is an Axis-custom piece of hardware? (Would make
> sense.)
> 
> Please expand this acronym and state clearly that (if this
> is a correct assumption) that you are not supplying any
> bindings and even less a driver for the "CMU" thing, just the
> clocks. (That's fine the actual CMU can come later, but
> it should be clear *what* it is.)

Ok, I will add CMU abbreviation on cover-letter and respective patches.

Thanks,
Hakyeong Kim

> 
> Yours,
> Linus Walleij