linux-kernel - Re: [PATCH] media: stk1160: Restore deleted comment in stk1160_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xvj4llvckgxorozvk4bexcsdawohe5n3bbfsk4pmwg75rp2spk@2jy3qugcfiaa>
Date: Mon, 21 Jul 2025 13:02:57 +0800
From: Xu Yang <xu.yang_2@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] media: stk1160: Restore deleted comment in
 stk1160_fill_urb()

On Tue, Jul 15, 2025 at 06:00:32PM -0500, Dan Carpenter wrote:
> This comment explains why we return success when usb_alloc_noncoherent()
> fails and I think it's helpful.  It was deleted during a recent refactor,
> but let's add it back.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Xu Yang <xu.yang_2@....com>

Thanks,
Xu Yang

> ---
>  drivers/media/usb/stk1160/stk1160-video.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/stk1160/stk1160-video.c b/drivers/media/usb/stk1160/stk1160-video.c
> index 416cb74377eb..3e6bffd49346 100644
> --- a/drivers/media/usb/stk1160/stk1160-video.c
> +++ b/drivers/media/usb/stk1160/stk1160-video.c
> @@ -408,8 +408,13 @@ static int stk1160_fill_urb(struct stk1160 *dev, struct stk1160_urb *stk_urb,
>  	stk_urb->transfer_buffer = usb_alloc_noncoherent(dev->udev, sb_size,
>  							 GFP_KERNEL, &stk_urb->dma,
>  							 DMA_FROM_DEVICE, &stk_urb->sgt);
> -	if (!stk_urb->transfer_buffer)
> +	if (!stk_urb->transfer_buffer) {
> +		/*
> +		 * If the buffer allocation failed, we exit but return 0 since
> +		 * we allow the driver working with less buffers.
> +		 */
>  		goto free_urb;
> +	}
>  
>  	stk_urb->dev = dev;
>  	return 0;
> -- 
> 2.47.2
>