linux-kernel - Re: [PATCH v2 2/3] staging: rtl8723bs: fix comment formatting in basic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025072133-aspirin-backlash-2084@gregkh>
Date: Mon, 21 Jul 2025 07:54:43 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ali Nasrolahi <a.nasrolahi01@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 2/3] staging: rtl8723bs: fix comment formatting in
 basic_types.h

On Sun, Jul 20, 2025 at 06:25:23PM +0330, Ali Nasrolahi wrote:
> Fix coding style issues reported by checkpatch.pl:
> - Adjusted block comment trailing markers
> - Unified comment spacing and indentation

These two are fine, but:

> - Removed redundant semicolon from macro definition

This needs to be a separate patch.

Again, each patch needs to do only one "logical" thing.  And that
logical thing can not be "fix a bunch of coding style issues that are of
different types", sorry.

Please fix up for this patch, and the 3/3 patch and submit an updated
series.

thanks,

greg k-h