linux-kernel - Re: [BUG] xfs: Assertion failed in xfs_iwalk_args triggered by XFS_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aH3fXv5tlfGtzVD1@infradead.org>
Date: Sun, 20 Jul 2025 23:34:06 -0700
From: Christoph Hellwig <hch@...radead.org>
To: cen zhang <zzzccc427@...il.com>
Cc: cem@...nel.org, linux-kernel@...r.kernel.org, baijiaju1990@...il.com,
	zhenghaoran154@...il.com, r33s3n6@...il.com, gality365@...il.com,
	linux-xfs@...r.kernel.org
Subject: Re: [BUG] xfs: Assertion failed in xfs_iwalk_args triggered by
 XFS_IOC_INUMBERS

The patch below should fix the issue.  But I wonder if we should split
the flags a bit better to make things more obvious.

diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c
index c8c9b8d8309f..302efe54e2af 100644
--- a/fs/xfs/xfs_itable.c
+++ b/fs/xfs/xfs_itable.c
@@ -457,7 +457,8 @@ xfs_inumbers(
 	 * locking abilities to detect cycles in the inobt without deadlocking.
 	 */
 	tp = xfs_trans_alloc_empty(breq->mp);
-	error = xfs_inobt_walk(breq->mp, tp, breq->startino, breq->flags,
+	error = xfs_inobt_walk(breq->mp, tp, breq->startino,
+			breq->flags & XFS_IBULK_SAME_AG,
 			xfs_inumbers_walk, breq->icount, &ic);
 	xfs_trans_cancel(tp);