linux-kernel - Re: [PATCH 2/2] arm64: dts: mediatek: add crypto offload support on MT7981

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250721-camouflaged-dramatic-rattlesnake-e7f87f@kuoka>
Date: Mon, 21 Jul 2025 11:36:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aleksander Jan Bajkowski <olek2@...pl>
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, matthias.bgg@...il.com, 
	angelogioacchino.delregno@...labora.com, atenart@...nel.org, linux-crypto@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: add crypto offload support on
 MT7981

On Sun, Jul 20, 2025 at 07:49:03PM +0200, Aleksander Jan Bajkowski wrote:
> The MT7981 as well as the MT7986 have a built-in EIP-97 crypto accelerator.
> This commit adds the missing entry in the dts.
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>
> ---
>  arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> index 5cbea9cd411f..ebab8dde1e70 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> @@ -94,6 +94,20 @@ pwm@...48000 {
>  			#pwm-cells = <2>;
>  		};
>  
> +		crypto@...20000 {
> +			compatible = "inside-secure,safexcel-eip97";

Missing SoC compatible. You should not use IP block compatibles alone
and your previous patch explains why: some wires can be connected
differently.

Best regards,
Krzysztof