linux-kernel - Re: [PATCH v4 1/7] drm/panthor: Add GPU specific initialization framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e509e1a1-a9ca-4b16-82ab-916ad735a67a@arm.com>
Date: Mon, 21 Jul 2025 12:28:22 +0100
From: Karunika Choo <karunika.choo@....com>
To: Chia-I Wu <olvaffe@...il.com>
Cc: dri-devel@...ts.freedesktop.org, nd@....com,
 Boris Brezillon <boris.brezillon@...labora.com>,
 Steven Price <steven.price@....com>, Liviu Dudau <liviu.dudau@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/7] drm/panthor: Add GPU specific initialization
 framework

On 11/06/2025 00:12, Chia-I Wu wrote:
> On Mon, Jun 2, 2025 at 7:33 AM Karunika Choo <karunika.choo@....com> wrote:
>>
>> This patch provides an initialization framework for multiple Mali GPUs
>> by introducing a GPU support look-up table. Each entry contains, at
>> minimum, the architecture major version of the GPU, and may optionally
>> provide feature flags and register offset overrides.
> <snipped>
>> +/**
>> + * struct panthor_hw - GPU specific register mapping and functions
>> + */
>> +struct panthor_hw {
>> +       /** @arch_major: Architecture major to match against */
>> +       u32 arch_major;
>> +
>> +       /** @features: Bitmap containing panthor_hw_feature */
>> +       DECLARE_BITMAP(features, PANTHOR_HW_FEATURES_END);
>> +
>> +       /** @map: Panthor regmap */
>> +       struct panthor_hw_regmap map;
>> +
>> +       /** @ops: Panthor HW specific operations */
>> +       struct panthor_hw_ops ops;
>> +};
> None of the fields are really needed even at the end of this series.
> 
> Can we merge patch 1 & 2, introduce just panthor_hw_init and nothing
> else, and let panthor_hw_init call panthor_gpu_init_info?

Hello, I have tried to address this in PATCH 1/6 of v5:
- https://lore.kernel.org/all/20250721111344.1610250-2-karunika.choo@arm.com/

> 
> 
>> +
>> +int panthor_hw_init(struct panthor_device *ptdev);
>> +
>> +bool panthor_hw_supports(struct panthor_device *ptdev,
>> +                        enum panthor_hw_feature feature);
>> +
>> +#endif /* __PANTHOR_HW_H__ */
>> +
>> --
>> 2.49.0
>>