linux-kernel - Re: [PATCH v1 5/7] misc: qcom-coincell: Migrate to devm_spmi_subdevice_alloc_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507211953.9ai6l420-lkp@intel.com>
Date: Mon, 21 Jul 2025 19:30:53 +0800
From: kernel test robot <lkp@...el.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	sboyd@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, jic23@...nel.org, dlechner@...libre.com,
	nuno.sa@...log.com, andy@...nel.org, arnd@...db.de,
	gregkh@...uxfoundation.org, srini@...nel.org, vkoul@...nel.org,
	kishon@...nel.org, sre@...nel.org, krzysztof.kozlowski@...aro.org,
	u.kleine-koenig@...libre.com,
	angelogioacchino.delregno@...labora.com,
	linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
	linux-pm@...r.kernel.org, kernel@...labora.com, wenst@...omium.org
Subject: Re: [PATCH v1 5/7] misc: qcom-coincell: Migrate to
 devm_spmi_subdevice_alloc_and_add()

Hi AngeloGioacchino,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20250718]
[cannot apply to jic23-iio/togreg sre-power-supply/for-next char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.16-rc7 v6.16-rc6 v6.16-rc5 v6.16-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/spmi-Implement-spmi_subdevice_alloc_and_add-and-devm-variant/20250721-155809
base:   next-20250718
patch link:    https://lore.kernel.org/r/20250721075525.29636-6-angelogioacchino.delregno%40collabora.com
patch subject: [PATCH v1 5/7] misc: qcom-coincell: Migrate to devm_spmi_subdevice_alloc_and_add()
config: x86_64-buildonly-randconfig-003-20250721 (https://download.01.org/0day-ci/archive/20250721/202507211953.9ai6l420-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250721/202507211953.9ai6l420-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507211953.9ai6l420-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: vmlinux.o: in function `qcom_coincell_probe':
>> drivers/misc/qcom-coincell.c:111: undefined reference to `devm_spmi_subdevice_alloc_and_add'
>> ld: drivers/misc/qcom-coincell.c:115: undefined reference to `__devm_regmap_init_spmi_ext'


vim +111 drivers/misc/qcom-coincell.c

    83	
    84	static int qcom_coincell_probe(struct platform_device *pdev)
    85	{
    86		struct regmap_config qcom_coincell_regmap_config = {
    87			.reg_bits = 16,
    88			.val_bits = 16,
    89			.max_register = 0x100,
    90			.fast_io = true
    91		};
    92		struct device_node *node = pdev->dev.of_node;
    93		struct spmi_subdevice *sub_sdev;
    94		struct spmi_device *sparent;
    95		struct qcom_coincell chgr;
    96		u32 rset = 0;
    97		u32 vset = 0;
    98		bool enable;
    99		int rc;
   100	
   101		chgr.dev = &pdev->dev;
   102	
   103		rc = of_property_read_u32(node, "reg", &qcom_coincell_regmap_config.reg_base);
   104		if (rc)
   105			return rc;
   106	
   107		sparent = to_spmi_device(pdev->dev.parent);
   108		if (!sparent)
   109			return -ENODEV;
   110	
 > 111		sub_sdev = devm_spmi_subdevice_alloc_and_add(&pdev->dev, sparent);
   112		if (IS_ERR(sub_sdev))
   113			return PTR_ERR(sub_sdev);
   114	
 > 115		chgr.regmap = devm_regmap_init_spmi_ext(&sub_sdev->sdev,
   116							&qcom_coincell_regmap_config);
   117		if (!chgr.regmap) {
   118			dev_err(chgr.dev, "Unable to get regmap\n");
   119			return -EINVAL;
   120		}
   121	
   122		enable = !of_property_read_bool(node, "qcom,charger-disable");
   123	
   124		if (enable) {
   125			rc = of_property_read_u32(node, "qcom,rset-ohms", &rset);
   126			if (rc) {
   127				dev_err(chgr.dev,
   128					"can't find 'qcom,rset-ohms' in DT block");
   129				return rc;
   130			}
   131	
   132			rc = of_property_read_u32(node, "qcom,vset-millivolts", &vset);
   133			if (rc) {
   134				dev_err(chgr.dev,
   135				    "can't find 'qcom,vset-millivolts' in DT block");
   136				return rc;
   137			}
   138		}
   139	
   140		return qcom_coincell_chgr_config(&chgr, rset, vset, enable);
   141	}
   142	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki