linux-kernel - Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d7707cc-0a49-47a6-b222-9032f08bac0c@kernel.org>
Date: Mon, 21 Jul 2025 13:38:59 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peng Fan <peng.fan@....nxp.com>, Luca Weiss <luca.weiss@...rphone.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Manivannan Sadhasivam <mani@...nel.org>,
 ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document
 remoteprocs

On 21/07/2025 08:42, Peng Fan wrote:
>> +
>> +  interrupt-names:
>> +    minItems: 6
>> +    maxItems: 6
> 
> Ditto.
> 
> Do you need to define the list?


Did you read the entire binding? It reminds me Frank's comment as well -
instead of actually checking you just ask question which you would find
answer by yourselves if you really opened the code.

> 
>> +
>> +  qcom,qmp:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: Reference to the AOSS side-channel message RAM.
>> +
>> +  smd-edge: false
>> +
>> +  firmware-name:
>> +    $ref: /schemas/types.yaml#/definitions/string-array
>> +    minItems: 1
>> +    items:
>> +      - description: Firmware name of the Hexagon core
>> +      - description: Firmware name of the Hexagon Devicetree
>> +
>> +  memory-region:
>> +    minItems: 1
>> +    items:
>> +      - description: Memory region for core Firmware authentication
>> +      - description: Memory region for Devicetree Firmware authentication
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - memory-region
>> +
>> +allOf:
>> +  - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,milos-adsp-pas
>> +            - qcom,milos-cdsp-pas
>> +    then:
>> +      properties:
>> +        memory-region:
>> +          minItems: 2
>> +          maxItems: 2
>> +        firmware-name:
>> +          minItems: 2
>> +          maxItems: 2
> 
> Just keep minItems if maxItems is same value.


This is not a correct advice.


Best regards,
Krzysztof