linux-kernel - Re: [PATCH v5 1/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f327a84d-8979-438d-aa05-c64472a93c16@kernel.org>
Date: Mon, 21 Jul 2025 14:34:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-leds@...r.kernel.org,
 linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>,
 devicetree@...r.kernel.org, Lucca Fachinetti <luccafachinetti@...il.com>
Subject: Re: [PATCH v5 1/3] dt-bindings: leds: is31fl32xx: convert the binding
 to yaml

On 21/07/2025 14:26, Pawel Zalewski wrote:
>> This still does not match min/max constraints. You already got the
>> comment on this and nothing improved.
> 
> It was not clear to me what you are after, so you want the pattern to be:
> 
> ^led@(?:[1-9a-f]|1[0-9a-f]|2[0-4])$

led@([1-9a-f]|1[0-9a-f]|2[0-4])$
should be enough


> 
> So the range of the unit@ string is controlled via the pattern
> orthogonal to reg,
> the range of the reg property explicitly via minimum/maximum which are decimal,
> despite the fact that the reg itself can be a hex value, which is
> preferred for readability

Yes, just write min/max decimal in the list. It's not an address, but index.

Best regards,
Krzysztof