linux-kernel - Re: [PATCH v1 4/7] phy: qualcomm: eusb2-repeater: Migrate to devm_spmi_subdevice_alloc_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507212056.GmiGorFf-lkp@intel.com>
Date: Mon, 21 Jul 2025 21:10:13 +0800
From: kernel test robot <lkp@...el.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	sboyd@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, jic23@...nel.org,
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
	arnd@...db.de, gregkh@...uxfoundation.org, srini@...nel.org,
	vkoul@...nel.org, kishon@...nel.org, sre@...nel.org,
	krzysztof.kozlowski@...aro.org, u.kleine-koenig@...libre.com,
	angelogioacchino.delregno@...labora.com,
	linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
	linux-pm@...r.kernel.org, kernel@...labora.com, wenst@...omium.org
Subject: Re: [PATCH v1 4/7] phy: qualcomm: eusb2-repeater: Migrate to
 devm_spmi_subdevice_alloc_and_add()

Hi AngeloGioacchino,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20250718]
[cannot apply to jic23-iio/togreg sre-power-supply/for-next char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.16-rc7 v6.16-rc6 v6.16-rc5 v6.16-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/spmi-Implement-spmi_subdevice_alloc_and_add-and-devm-variant/20250721-155809
base:   next-20250718
patch link:    https://lore.kernel.org/r/20250721075525.29636-5-angelogioacchino.delregno%40collabora.com
patch subject: [PATCH v1 4/7] phy: qualcomm: eusb2-repeater: Migrate to devm_spmi_subdevice_alloc_and_add()
config: i386-buildonly-randconfig-002-20250721 (https://download.01.org/0day-ci/archive/20250721/202507212056.GmiGorFf-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250721/202507212056.GmiGorFf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507212056.GmiGorFf-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c:221:59: warning: variable 'sparent' is uninitialized when used here [-Wuninitialized]
     221 |         sub_sdev = devm_spmi_subdevice_alloc_and_add(&pdev->dev, sparent);
         |                                                                  ^~~~~~~
   drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c:202:29: note: initialize the variable 'sparent' to silence this warning
     202 |         struct spmi_device *sparent;
         |                                    ^
         |                                     = NULL
   1 warning generated.


vim +/sparent +221 drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c

   193	
   194	static int eusb2_repeater_probe(struct platform_device *pdev)
   195	{
   196		struct regmap_config eusb2_regmap_config = {
   197			.reg_bits = 16,
   198			.val_bits = 16,
   199			.max_register = 0x100,
   200			.fast_io = true
   201		};
   202		struct spmi_device *sparent;
   203		struct eusb2_repeater *rptr;
   204		struct spmi_subdevice *sub_sdev;
   205		struct device *dev = &pdev->dev;
   206		struct phy_provider *phy_provider;
   207		struct device_node *np = dev->of_node;
   208		int ret;
   209	
   210		rptr = devm_kzalloc(dev, sizeof(*rptr), GFP_KERNEL);
   211		if (!rptr)
   212			return -ENOMEM;
   213	
   214		rptr->dev = dev;
   215		dev_set_drvdata(dev, rptr);
   216	
   217		rptr->cfg = of_device_get_match_data(dev);
   218		if (!rptr->cfg)
   219			return -EINVAL;
   220	
 > 221		sub_sdev = devm_spmi_subdevice_alloc_and_add(&pdev->dev, sparent);
   222		if (IS_ERR(sub_sdev))
   223			return PTR_ERR(sub_sdev);
   224	
   225		ret = of_property_read_u32(np, "reg", &eusb2_regmap_config.reg_base);
   226		if (ret < 0)
   227			return ret;
   228	
   229		rptr->regmap = devm_regmap_init_spmi_ext(&sub_sdev->sdev, &eusb2_regmap_config);
   230		if (IS_ERR(rptr->regmap))
   231			return -ENODEV;
   232	
   233		ret = eusb2_repeater_init_vregs(rptr);
   234		if (ret < 0) {
   235			dev_err(dev, "unable to get supplies\n");
   236			return ret;
   237		}
   238	
   239		rptr->phy = devm_phy_create(dev, np, &eusb2_repeater_ops);
   240		if (IS_ERR(rptr->phy)) {
   241			dev_err(dev, "failed to create PHY: %d\n", ret);
   242			return PTR_ERR(rptr->phy);
   243		}
   244	
   245		phy_set_drvdata(rptr->phy, rptr);
   246	
   247		phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
   248		if (IS_ERR(phy_provider))
   249			return PTR_ERR(phy_provider);
   250	
   251		return 0;
   252	}
   253	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki