linux-kernel - Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86bbb4c1-18a9-4917-8554-97d540b72b5a@ti.com>
Date: Mon, 21 Jul 2025 19:42:57 +0530
From: "Kumar, Udit" <u-kumar1@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Yemike Abhilash Chandra
	<y-abhilashchandra@...com>, <nm@...com>,
        <vigneshr@...com>
CC: <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <vaishnav.a@...com>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <imx@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        <u-kumar1@...com>
Subject: Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts
 property


On 7/21/2025 7:39 PM, Krzysztof Kozlowski wrote:
> On 21/07/2025 16:07, Kumar, Udit wrote:
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> index 62f45377a2c9..6f32a2b0c40c 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@...0000 {
>>>    		cdns_csi2rx0: csi-bridge@...4000 {
>>>    			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>    			reg = <0x00 0x04504000 0x00 0x1000>;
>>> +			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>> Just cosmetic thing, if you are doing v2 then consider 152 first ,
>> followed by 153.
>
> No, you cannot just randomly change numbers or the order.
>
To be precise both , interrupt-names and interrupts,

if this make sense to change.


> Best regards,
> Krzysztof