linux-kernel - Re: [PATCH] usb: gadget: f_uac1: replace scnprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025072103-pointing-ravioli-493b@gregkh>
Date: Mon, 21 Jul 2025 16:31:26 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Sumanth Gavini <sumanth.gavini@...oo.com>
Cc: crwulff@...il.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	david.hunter.linux@...il.com
Subject: Re: [PATCH] usb: gadget: f_uac1: replace scnprintf() with
 sysfs_emit()

On Fri, Jul 18, 2025 at 12:50:35PM -0500, Sumanth Gavini wrote:
> Documentation/filesystems/sysfs.rst mentions that show() should only
> use sysfs_emit() or sysfs_emit_at() when formating the value to be
> returned to user space. So replace scnprintf() with sysfs_emit().
> 
> Signed-off-by: Sumanth Gavini <sumanth.gavini@...oo.com>
> ---
>  drivers/usb/gadget/function/f_uac1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c
> index c87e74afc881..9da9fb4e1239 100644
> --- a/drivers/usb/gadget/function/f_uac1.c
> +++ b/drivers/usb/gadget/function/f_uac1.c
> @@ -1634,7 +1634,7 @@ static ssize_t f_uac1_opts_##name##_show(struct config_item *item,	\
>  	int result;							\
>  									\
>  	mutex_lock(&opts->lock);					\
> -	result = scnprintf(page, sizeof(opts->name), "%s", opts->name);	\
> +	result = sysfs_emit(page, "%s", opts->name);        	        \
>  	mutex_unlock(&opts->lock);					\
>  									\
>  	return result;							\
> -- 
> 2.43.0
> 
> 

Note, this really isn't needed at all, you should only use sysfs_emit()
for new code, but this "cleanup" is simple enough...