linux-kernel - Re: [PATCH next] drm/xe: Fix an IS_ERR() vs NULL bug in xe_tile_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aH5RQTOMVdQrv-a7@intel.com>
Date: Mon, 21 Jul 2025 10:40:01 -0400
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Piotr Piórkowski <piotr.piorkowski@...el.com>, "Lucas
 De Marchi" <lucas.demarchi@...el.com>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, David Airlie <airlied@...il.com>, "Simona
 Vetter" <simona@...ll.ch>, Matthew Brost <matthew.brost@...el.com>, "Matthew
 Auld" <matthew.auld@...el.com>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] drm/xe: Fix an IS_ERR() vs NULL bug in
 xe_tile_alloc_vram()

On Fri, Jul 18, 2025 at 04:23:05PM -0500, Dan Carpenter wrote:
> The xe_vram_region_alloc() function returns NULL on error.  It never
> returns error pointers.  Update the error checking to match.
> 
> Fixes: 4b0a5f5ce784 ("drm/xe: Unify the initialization of VRAM regions")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/gpu/drm/xe/xe_tile.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
> index 0be0a5c57ef4..d49ba3401963 100644
> --- a/drivers/gpu/drm/xe/xe_tile.c
> +++ b/drivers/gpu/drm/xe/xe_tile.c
> @@ -120,8 +120,8 @@ int xe_tile_alloc_vram(struct xe_tile *tile)
>  		return 0;
>  
>  	vram = xe_vram_region_alloc(xe, tile->id, XE_PL_VRAM0 + tile->id);
> -	if (IS_ERR(vram))
> -		return PTR_ERR(vram);
> +	if (!vram)
> +		return -ENOMEM;

Indeed correct, from the drmm_kmalloc to the probe where it is consumed.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@...el.com>

and pushed to drm-xe-next

>  	tile->mem.vram = vram;
>  
>  	return 0;
> -- 
> 2.47.2
>