linux-kernel - Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aH5S_IlGAp5Myezx@intel.com>
Date: Mon, 21 Jul 2025 10:47:24 -0400
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: Ruben Wauters <rubenru09@....com>
CC: Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	<intel-gfx@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with
 DRM_KUNIT_TEST

On Fri, Jul 18, 2025 at 12:19:41PM -0400, Rodrigo Vivi wrote:
> On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote:
> > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote:
> > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest:
> > > convert drm_mm selftest to KUnit) and all functions under it were
> > > converted to KUnit, under the DRM_KUNIT_TEST option
> > > 
> > > This conversion however did not occur in the Kconfig.debug file in
> > > the
> > > i915 directory.
> 
> I wonder if some deeper conversion is needed on the selftests.
> But well, I couldn't spot anything and if CI is happy, let's go with ti.
> 
> > > 
> > > This patch replaces the select for DRM_DEBUG_SELFTEST, an option that
> > > no
> > > longer exists, with the correct select, DRM_KUNIT_TEST.
> > > 
> > > Signed-off-by: Ruben Wauters <rubenru09@....com>
> > > ---
> > > v2 changes:
> > > - update commit message to contain more detail about the background
> > > of
> > >   the change and why it is necessary
> > > ---
> > >  drivers/gpu/drm/i915/Kconfig.debug | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug
> > > b/drivers/gpu/drm/i915/Kconfig.debug
> > > index 1852e0804942..b15b1cecb3aa 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > @@ -50,7 +50,7 @@ config DRM_I915_DEBUG
> > >  	select DRM_VGEM # used by igt/prime_vgem (dmabuf interop
> > > checks)
> > >  	select DRM_DEBUG_MM if DRM=y
> > >  	select DRM_EXPORT_FOR_TESTS if m
> > > -	select DRM_DEBUG_SELFTEST
> > > +	select DRM_KUNIT_TEST
> > >  	select DMABUF_SELFTESTS
> > >  	select SW_SYNC # signaling validation framework
> > > (igt/syncobj*)
> > >  	select DRM_I915_WERROR
> > 
> > Hello, I was wondering if it'd be possible to have this patch reviewed.
> > Having an incorrect Kconfig entry isn't ideal and it'd be good if this
> > could be fixed if possible
> 
> I just resent for CI before we can merge.

pushed to drm-intel-next

Thanks for the patch.

> 
> Thanks for the patch...
> 
> > 
> > Thanks
> > 
> > Ruben Wauters