linux-kernel - Re: [PATCH v4] ALSA: usb-audio: qcom: Adjust mutex unlock order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21c3aec1-0284-471f-b336-cdcc832ac6fe@web.de>
Date: Mon, 21 Jul 2025 17:00:05 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Erick Karanja <karanja99erick@...il.com>, linux-sound@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v4] ALSA: usb-audio: qcom: Adjust mutex unlock order

> The mutexes qdev_mutex and chip->mutex are acquired in that order
> throughout the driver. To preserve proper lock hierarchy and avoid
> potential deadlocks, they must be released in the reverse
> order of acquisition.

Would you become interested to benefit any more from lock guards?
https://elixir.bootlin.com/linux/v6.16-rc6/source/include/linux/mutex.h#L225

Regards,
Markus