[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ba84629f-5675-4793-9320-25d9029d2a35@kernel.org>
Date: Tue, 22 Jul 2025 16:02:21 +0100
From: Quentin Monnet <qmo@...nel.org>
To: Tao Chen <chen.dylane@...ux.dev>, ast@...nel.org, daniel@...earbox.net,
andrii@...nel.org, martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, davem@...emloft.net,
kuba@...nel.org, hawk@...nel.org
Cc: linux-kernel@...r.kernel.org, bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 3/3] bpftool: Add bash completion for token
argument
2025-07-22 20:09 UTC+0800 ~ Tao Chen <chen.dylane@...ux.dev>
> This commit updates the bash completion script with the new token
> argument.
> $ bpftool
> batch cgroup gen iter map perf struct_ops
> btf feature help link net prog token
This is a terrible example, offering "token" as completion for just
"bpftool [tab]" works without this patch :) The main commands are parsed
from the output of "bpftool help" so it should work after your first
patch. In this one, we add "list", "show" and "help" for completing
"bpftool token [tab]".
>
> Signed-off-by: Tao Chen <chen.dylane@...ux.dev>
> ---
> tools/bpf/bpftool/bash-completion/bpftool | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
> index a759ba24471..527bb47ac46 100644
> --- a/tools/bpf/bpftool/bash-completion/bpftool
> +++ b/tools/bpf/bpftool/bash-completion/bpftool
> @@ -1215,6 +1215,17 @@ _bpftool()
> ;;
> esac
> ;;
> + token)
> + case $command in
> + show|list)
> + return 0
> + ;;
> + *)
> + [[ $prev == $object ]] && \
> + COMPREPLY=( $( compgen -W 'help show list' -- "$cur" ) )
> + ;;
> + esac
> + ;;
> esac
> } &&
> complete -F _bpftool bpftool
Other than the example in the description, this looks good.
Reviewed-by: Quentin Monnet <qmo@...nel.org>
Thanks
Powered by blists - more mailing lists