linux-kernel - Re: [PATCH] resource: fix false warning in __request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <687fb78c8d44b_134cc7100f@dwillia2-xfh.jf.intel.com.notmuch>
Date: Tue, 22 Jul 2025 09:08:44 -0700
From: <dan.j.williams@...el.com>
To: Akinobu Mita <akinobu.mita@...il.com>, Andrew Morton
	<akpm@...ux-foundation.org>
CC: <linux-kernel@...r.kernel.org>, <linux-cxl@...r.kernel.org>
Subject: Re: [PATCH] resource: fix false warning in __request_region()

Akinobu Mita wrote:
> 2025年7月20日(日) 8:31 Andrew Morton <akpm@...ux-foundation.org>:
> >
> > On Sat, 19 Jul 2025 20:26:04 +0900 Akinobu Mita <akinobu.mita@...il.com> wrote:
> >
> > > A warning is raised when __request_region() detects a conflict with a
> > > resource whose resource.desc is IORES_DESC_DEVICE_PRIVATE_MEMORY.
> > >
> > > But this warning is only valid for iomem_resources.
> > > The hmem device resource uses resource.desc as the numa node id, which can
> > > cause spurious warnings.
> > >
> > > This change fixes this by restricting the warning to only iomem_resource.
> > > This also adds a missing new line to the warning message.
> >
> > What are the circumstance which cause this warning?  Are real world
> > users hitting this?  If so, should we backport this fix into earlier
> > kernels?
> 
> This warning actually appeared on a machine with multiple cxl memory expanders.
> One of the NUMA node id is 6, which is the same as the value of
> IORES_DESC_DEVICE_PRIVATE_MEMORY.
> 
> In this environment it was just a spurious warning, but when I saw the warning
> I suspected a real problem so it's better to fix it.
> 
> Fixes: b926b7f3baec ("mm/resource: Move HMM pr_debug() deeper into
> resource code")

This should be:

Fixes: 7dab174e2e27 ("dax/hmem: Move hmem device registration to dax_hmem.ko")

...as that is the change that violates the assumptions of
__request_region().

You can add:

Reviewed-by: Dan Williams <dan.j.williams@...el.com>