linux-kernel - Re: [PATCH] crypto: caam - switch to use devm_kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac2ace68-e88f-4055-9b01-45a2eaab50fc@wanadoo.fr>
Date: Tue, 22 Jul 2025 19:03:54 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: zhang.enpei@....com.cn
Cc: horia.geanta@....com, pankaj.gupta@....com, gaurav.jain@....com,
 herbert@...dor.apana.org.au, davem@...emloft.net,
 linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: caam - switch to use devm_kmemdup_array()

Le 21/07/2025 à 04:06, zhang.enpei@....com.cn a écrit :
> Thanks for the review!
> devm_kmemdup_array() will call size_mul() to combine its third and fourth parameters into
> length for devm_kmemdup(). So keep the same value sizeof(data->clks[0]) here as before.
> 
> 

sizeof(data->clks[0]) and sizeof(*data->clks) are the same.

But the second version is the preferred style. See [1].

So while touching these lines of code, updating the style looked a good 
idea to me.

CJ


[1]: 
https://docs.kernel.org/6.15/process/coding-style.html#allocating-memory