linux-kernel - Re: [PATCH v4] ALSA: usb-audio: qcom: Adjust mutex unlock order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a674f481-f954-4e32-8336-bb3d9ae8c68c@web.de>
Date: Tue, 22 Jul 2025 21:22:37 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Takashi Iwai <tiwai@...e.de>, Erick Karanja <karanja99erick@...il.com>,
 linux-sound@...r.kernel.org
Cc: Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] ALSA: usb-audio: qcom: Adjust mutex unlock order

…
> > +++ b/sound/usb/qcom/qc_audio_offload.c
…
> > @@ -1865,8 +1865,8 @@ static void qc_usb_audio_offload_disconnect(struct snd_usb_audio *chip)
> >  
> >  	/* Device has already been cleaned up, or never populated */
> >  	if (!dev->chip) {
> > -		mutex_unlock(&qdev_mutex);
> >  		mutex_unlock(&chip->mutex);
> > +		mutex_unlock(&qdev_mutex);
> >  		return;
> >  	}
> >  
…
> In anyway, I applied the patch now.

How do you think about to refine this function implementation another bit
by using an additional label like “unlock” rather than keeping duplicate
source code?


Regards,
Markus