linux-kernel - Re: [PATCH] tracing: sched: Hide numa balancing trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250722190016.7c462d56@gandalf.local.home>
Date: Tue, 22 Jul 2025 19:00:16 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: LKML <linux-kernel@...r.kernel.org>, Linux trace kernel
 <linux-trace-kernel@...r.kernel.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Ingo Molnar <mingo@...nel.org>, Peter
 Zijlstra <peterz@...radead.org>, Vincent Guittot
 <vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>
Subject: Re: [PATCH] tracing: sched: Hide numa balancing trace events

On Tue, 22 Jul 2025 10:48:20 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The trace events sched_move_numa, sched_swap_numa and sched_stick_numa are
> only used when CONFIG_NUMA_BALANCING is enabled. Put an #ifdef guard
> around the definitions of these trace events so they are not defined when
> numa balancing is not enabled, otherwise they waste a bit of memory being
> unused.
> 

I just noticed that I already sent out a version of this patch here:

  https://lore.kernel.org/linux-trace-kernel/20250612100552.39672cf9@batman.local.home/

Which is a better version than this one.

> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>  include/trace/events/sched.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
> index 4e6b2910cec3..51776b45549a 100644
> --- a/include/trace/events/sched.h
> +++ b/include/trace/events/sched.h
> @@ -628,6 +628,7 @@ TRACE_EVENT(sched_process_hang,
>  );
>  #endif /* CONFIG_DETECT_HUNG_TASK */
>  
> +#ifdef CONFIG_NUMA_BALANCING
>  /*
>   * Tracks migration of tasks from one runqueue to another. Can be used to
>   * detect if automatic NUMA balancing is bouncing between nodes.
> @@ -719,6 +720,7 @@ DEFINE_EVENT(sched_numa_pair_template, sched_swap_numa,
>  
>  	TP_ARGS(src_tsk, src_cpu, dst_tsk, dst_cpu)
>  );
> +#endif /* CONFIG_NUMA_BALANCING */
>  
>  #ifdef CONFIG_NUMA_BALANCING

Because You can just remove the above two CPP directives.

So please ignore this one.

-- Steve


>  #define NUMAB_SKIP_REASON					\