linux-kernel - Re: [PATCH bpf-next 2/2] umd: Remove usermode driver framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cy9rpzqc.fsf@email.froward.int.ebiederm.org>
Date: Tue, 22 Jul 2025 18:33:47 -0500
From: "Eric W. Biederman" <ebiederm@...ssion.com>
To: Christoph Hellwig <hch@....de>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>,  Thomas Weißschuh
 <thomas.weissschuh@...utronix.de>,  Alexander Viro
 <viro@...iv.linux.org.uk>,  Alexei Starovoitov <ast@...nel.org>,  Daniel
 Borkmann <daniel@...earbox.net>,  Andrii Nakryiko <andrii@...nel.org>,
  Martin KaFai Lau <martin.lau@...ux.dev>,  Eduard Zingerman
 <eddyz87@...il.com>,  Song Liu <song@...nel.org>,  Yonghong Song
 <yonghong.song@...ux.dev>,  John Fastabend <john.fastabend@...il.com>,  KP
 Singh <kpsingh@...nel.org>,  Stanislav Fomichev <sdf@...ichev.me>,  Hao
 Luo <haoluo@...gle.com>,  Jiri Olsa <jolsa@...nel.org>,  Linux-Fsdevel
 <linux-fsdevel@...r.kernel.org>,  bpf <bpf@...r.kernel.org>,  LKML
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next 2/2] umd: Remove usermode driver framework

Christoph Hellwig <hch@....de> writes:

> On Mon, Jul 21, 2025 at 08:51:22AM -0700, Alexei Starovoitov wrote:
>> On Mon, Jul 21, 2025 at 2:05 AM Thomas Weißschuh
>> <thomas.weissschuh@...utronix.de> wrote:
>> >
>> > The code is unused since commit 98e20e5e13d2 ("bpfilter: remove bpfilter"),
>> > remove it.
>> 
>> Correct, but we have plans to use it.
>> Since it's not causing any problems we prefer to keep it
>> to avoid reverting the removal later.
>
> Plans to eventually use something are no reason to keep code that's been
> unused for almost 2 years around.  Unless the removal would conflict with
> currently queued up in linux-next code it is always better to just drop
> it and reinstate it when (or rather usually IFF) it is used again.

I wonder if those are the same plans that existed in June of 2020 when I
split out the usermode driver code from user mode helper?

As far as I know this code has never been seriously used, so I am in
favor of simplifying the maintenance burden.

Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Eric