linux-kernel - Re: [PATCH v3] sparc: fix resource leak in jbusmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0fcc2727-b911-48b5-9aa1-17fb484c6b07@kernel.org>
Date: Tue, 22 Jul 2025 08:22:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: jackysliu <1972843537@...com>, markus.elfring@....de
Cc: andreas@...sler.com, davem@...emloft.net, linux-kernel@...r.kernel.org,
 sparclinux@...r.kernel.org
Subject: Re: [PATCH v3] sparc: fix resource leak in jbusmc_probe()

On 21/07/2025 09:55, jackysliu wrote:
> From: Siyang Liu <1972843537@...com>
> 
> In the jbusmc_probe function, the device node mem_node fetched
> via of_find_node_by_path("/memory") is not properly freed
> on all code paths.
> This can lead to leakage of device node reference counts,
> which may result in kernel resources not being released.
> 
> This issue was detected by rule based static tools
> developed by Tencent.
> 
> Fixes: e70140ba0d2b ("Get rid of 'remove_new' relic from platform driver struct")
> 
> Signed-off-by: Siyang Liu <1972843537@...com>
> ---
>  arch/sparc/kernel/chmc.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/sparc/kernel/chmc.c b/arch/sparc/kernel/chmc.c
> index d4c74d6b2e1b..fd20e4ee0971 100644
> --- a/arch/sparc/kernel/chmc.c
> +++ b/arch/sparc/kernel/chmc.c
> @@ -412,7 +412,7 @@ static int jbusmc_probe(struct platform_device *op)
>  	mem_regs = of_get_property(mem_node, "reg", &len);
>  	if (!mem_regs) {
>  		printk(KERN_ERR PFX "Cannot get reg property of /memory node.\n");
> -		goto out;
> +		goto out_put;

Nothing improved. You just ignored all the comments.

Best regards,
Krzysztof