[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <DM8PR11MB57509E1BD459582ADF8CC132E75CA@DM8PR11MB5750.namprd11.prod.outlook.com>
Date: Tue, 22 Jul 2025 06:46:02 +0000
From: "Reshetova, Elena" <elena.reshetova@...el.com>
To: "Hansen, Dave" <dave.hansen@...el.com>
CC: "jarkko@...nel.org" <jarkko@...nel.org>, "seanjc@...gle.com"
<seanjc@...gle.com>, "Huang, Kai" <kai.huang@...el.com>, "mingo@...nel.org"
<mingo@...nel.org>, "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"x86@...nel.org" <x86@...nel.org>, "Mallick, Asit K"
<asit.k.mallick@...el.com>, "Scarlata, Vincent R"
<vincent.r.scarlata@...el.com>, "Cai, Chong" <chongc@...gle.com>, "Aktas,
Erdem" <erdemaktas@...gle.com>, "Annapurve, Vishal" <vannapurve@...gle.com>,
"Bondarevska, Nataliia" <bondarn@...gle.com>, "Raynor, Scott"
<scott.raynor@...el.com>
Subject: RE: [PATCH v8 1/5] x86/sgx: Introduce a counter to count the
sgx_(vepc_)open()
> -----Original Message-----
> From: Hansen, Dave <dave.hansen@...el.com>
> Sent: Monday, July 21, 2025 7:48 PM
> To: Reshetova, Elena <elena.reshetova@...el.com>
> Cc: jarkko@...nel.org; seanjc@...gle.com; Huang, Kai
> <kai.huang@...el.com>; mingo@...nel.org; linux-sgx@...r.kernel.org; linux-
> kernel@...r.kernel.org; x86@...nel.org; Mallick, Asit K
> <asit.k.mallick@...el.com>; Scarlata, Vincent R <vincent.r.scarlata@...el.com>;
> Cai, Chong <chongc@...gle.com>; Aktas, Erdem <erdemaktas@...gle.com>;
> Annapurve, Vishal <vannapurve@...gle.com>; Bondarevska, Nataliia
> <bondarn@...gle.com>; Raynor, Scott <scott.raynor@...el.com>
> Subject: Re: [PATCH v8 1/5] x86/sgx: Introduce a counter to count the
> sgx_(vepc_)open()
>
> On 7/15/25 05:40, Elena Reshetova wrote:
> > +int sgx_inc_usage_count(void)
> > +{
> > + sgx_usage_count++;
> > + return 0;
> > +}
> > +
> > +void sgx_dec_usage_count(void)
> > +{
> > + sgx_usage_count--;
> > +}
>
> Gah.
>
> I know this gets fixed up later in the series with the mutex, but this
> code is broken and racy until that point.
>
> I'd rather this do _nothing_:
>
> int sgx_inc_usage_count(void)
> {
> return 0;
> }
>
> than a foo++ which just plain doesn't work.
Sure, I can fix it also in v9.
Best Regards,
Elena.
Powered by blists - more mailing lists