lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANn89iJLnprFvLpRpJ7_br5EiyCF0xqcMM7seUVQNAfroc4Taw@mail.gmail.com>
Date: Mon, 21 Jul 2025 23:51:51 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Haiyang Zhang <haiyangz@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, 
	haiyangz@...rosoft.com, kys@...rosoft.com, wei.liu@...nel.org, 
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, davem@...emloft.net, 
	sdf@...ichev.me, kuniyu@...gle.com, ahmed.zaki@...el.com, 
	aleksander.lobakin@...el.com, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org, #@...ux.microsoft.com, 5.4+@...ux.microsoft.com
Subject: Re: [PATCH net] net: core: Fix the loop in default_device_exit_net()

On Fri, Jul 18, 2025 at 1:21 PM Haiyang Zhang
<haiyangz@...ux.microsoft.com> wrote:
>
> From: Haiyang Zhang <haiyangz@...rosoft.com>
>
> The loop in default_device_exit_net() won't be able to properly detect the
> head then stop, and will hit NULL pointer, when a driver, like hv_netvsc,
> automatically moves the slave device together with the master device.
>
> To fix this, add a helper function to return the first migratable netdev
> correctly, no matter one or two devices were removed from this net's list
> in the last iteration.
>
> Cc: stable@...r.kernel.org # 5.4+

We (network maintainers) prefer a Fixes: tag, so that we can look at
the blamed patch, rather than trusting your '5.4' hint.

Without a Fixes tag, you are forcing each reviewer to do the
archeology work, and possibly completely miss your point.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ