linux-kernel - Re: [PATCH v3 1/2] staging: rtl8723bs: fix comment formatting in basic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025072209-retract-rocking-c69d@gregkh>
Date: Tue, 22 Jul 2025 09:37:30 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ali Nasrolahi <a.nasrolahi01@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v3 1/2] staging: rtl8723bs: fix comment formatting in
 basic_types.h

On Mon, Jul 21, 2025 at 08:13:42PM +0330, Ali Nasrolahi wrote:
> Signed-off-by: Ali Nasrolahi <A.Nasrolahi01@...il.com>
> ---
>  drivers/staging/rtl8723bs/include/basic_types.h | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h
> index 57bb717327c..e2f203910be 100644
> --- a/drivers/staging/rtl8723bs/include/basic_types.h
> +++ b/drivers/staging/rtl8723bs/include/basic_types.h
> @@ -26,7 +26,7 @@
>   *	1. Read/write packet content.
>   *	2. Before write integer to IO.
>   *	3. After read integer from IO.
> -*/
> + */
>  
>  /*  */
>  /*  Byte Swapping routine. */
> @@ -94,7 +94,7 @@
>  #define BIT_OFFSET_LEN_MASK_8(__bitoffset, __bitlen) \
>  	(BIT_LEN_MASK_8(__bitlen) << (__bitoffset))
>  
> -/*Description:
> +/* Description:
>   * Return 4-byte value in host byte ordering from
>   * 4-byte pointer in little-endian system.
>   */
> @@ -105,11 +105,10 @@
>  #define LE_P1BYTE_TO_HOST_1BYTE(__pstart) \
>  	(EF1BYTE(*((u8 *)(__pstart))))
>  
> -/*  */
> -/* 	Description: */
> -/* 		Translate subfield (continuous bits in little-endian) of 4-byte value in litten byte to */
> -/* 		4-byte value in host byte ordering. */
> -/*  */
> +/* Description:
> + *	Translate subfield (continuous bits in little-endian) of 4-byte value in litten byte to
> + *	4-byte value in host byte ordering.
> + */
>  #define LE_BITS_TO_4BYTE(__pstart, __bitoffset, __bitlen) \
>  	(\
>  		(LE_P4BYTE_TO_HOST_4BYTE(__pstart) >> (__bitoffset))  & \
> -- 
> 2.50.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot