linux-kernel - Re: [PATCH] dt-bindings: interrupt-controller: Add Xilinx INTC binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250722-viper-of-inevitable-adventure-23ba2d@kuoka>
Date: Tue, 22 Jul 2025 09:37:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, 
	michal.simek@...inx.com, git@...inx.com, Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Add Xilinx INTC
 binding

On Tue, Jul 22, 2025 at 09:32:58AM +0200, Michal Simek wrote:
> 
> 
> On 7/22/25 09:17, Krzysztof Kozlowski wrote:
> > On 22/07/2025 08:49, Michal Simek wrote:
> > > Add description for AMD/Xilinx interrupt controller.
> > > IP acts as primary interrupt controller on Microblaze systems or can be
> > > used as secondary interrupt controller on ARM based systems like Zynq,
> > > ZynqMP, Versal or Versal Gen 2. Also as secondary interrupt controller on
> > > Microblaze-V (Risc-V) systems.
> > > 
> > > Over the years IP exists in multiple variants based on attached bus as OPB,
> > > PLB or AXI that's why generic filename is used.
> > > 
> > > Signed-off-by: Michal Simek <michal.simek@....com>
> > > ---
> > > 
> > > https://docs.amd.com/v/u/en-US/pg099-axi-intc
> > 
> > 
> > We usually do not take bindings without users, that's why bindings patch
> > is always part of some other patchset. Commit msg also did not clarify
> > the usecase here (or exception).
> 
> Example DT is already the part of arch/microblaze/.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/microblaze/boot/dts/system.dts?h=v6.16-rc7#n338
> 
> DT has been added in 2014 before dt bindings that's why it was never documented.

OK, this must be in commit msg, because that's the reason why you are
doing it. You are not adding new device. You are documenting missing
binding, already used.

Best regards,
Krzysztof