linux-kernel - Re: [PATCH] accel/amdxdna: Delete pci_free_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc12ee3d-1b76-43e1-98a6-b5b647fbb603@linux.intel.com>
Date: Tue, 22 Jul 2025 09:55:36 +0200
From: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>
To: Salah Triki <salah.triki@...il.com>, Min Ma <min.ma@....com>,
 Lizhi Hou <lizhi.hou@....com>, Oded Gabbay <ogabbay@...nel.org>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] accel/amdxdna: Delete pci_free_irq_vectors()

Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>

On 7/19/2025 8:33 AM, Salah Triki wrote:
> The device is managed so pci_free_irq_vectors() is called automatically
> no need to do it manually.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  drivers/accel/amdxdna/aie2_pci.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c
> index c6cf7068d23c..3474a8d4e560 100644
> --- a/drivers/accel/amdxdna/aie2_pci.c
> +++ b/drivers/accel/amdxdna/aie2_pci.c
> @@ -520,14 +520,14 @@ static int aie2_init(struct amdxdna_dev *xdna)
>  	if (!ndev->psp_hdl) {
>  		XDNA_ERR(xdna, "failed to create psp");
>  		ret = -ENOMEM;
> -		goto free_irq;
> +		goto release_fw;
>  	}
>  	xdna->dev_handle = ndev;
>  
>  	ret = aie2_hw_start(xdna);
>  	if (ret) {
>  		XDNA_ERR(xdna, "start npu failed, ret %d", ret);
> -		goto free_irq;
> +		goto release_fw;
>  	}
>  
>  	ret = aie2_mgmt_fw_query(ndev);
> @@ -578,8 +578,6 @@ static int aie2_init(struct amdxdna_dev *xdna)
>  	aie2_error_async_events_free(ndev);
>  stop_hw:
>  	aie2_hw_stop(xdna);
> -free_irq:
> -	pci_free_irq_vectors(pdev);
>  release_fw:
>  	release_firmware(fw);
>  
> @@ -588,12 +586,10 @@ static int aie2_init(struct amdxdna_dev *xdna)
>  
>  static void aie2_fini(struct amdxdna_dev *xdna)
>  {
> -	struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev);
>  	struct amdxdna_dev_hdl *ndev = xdna->dev_handle;
>  
>  	aie2_hw_stop(xdna);
>  	aie2_error_async_events_free(ndev);
> -	pci_free_irq_vectors(pdev);
>  }
>  
>  static int aie2_get_aie_status(struct amdxdna_client *client,