linux-kernel - Re: [PATCH v2 00/11] HID: playstation: Add support for audio jack handling on DualSense

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab1c06b1-9b79-426a-a43b-cf5a89688770@collabora.com>
Date: Tue, 22 Jul 2025 11:03:40 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Roderick Colenbrander <thunderbird2k@...il.com>
Cc: Roderick Colenbrander <roderick.colenbrander@...y.com>,
 Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 Henrik Rydberg <rydberg@...math.org>, kernel@...labora.com,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 00/11] HID: playstation: Add support for audio jack
 handling on DualSense

Hi Roderick,

On 7/22/25 9:18 AM, Roderick Colenbrander wrote:
> Hi Cristian and Jiri,
> 
> One thing I forgot to bring up is whether it is best to have the audio
> plug logic have its separate input device or have it be part of an
> existing (e.g. main gamepad). The patch currently creates a separate
> input device. Originally we added multiple input devices (gamepad,
> touchpad and sensors) due to axes and button collisions really.
> 
> For this feature there is no collision. There are not many devices in
> the kernel, which support these audio EV_SW. I see for example the
> Switch 2 controller has a mini jack port as well. Some xbox
> controllers too (though audio not supported in the kernel from a quick
> glance or at least no HID or xpad driver features for them).
> 
> I don't have a strong opinion yet. Initial feeling was perhaps have it
> on the 'main' input device. But on the other hand, I'm not sure what
> software is normally listening for these kinds of EV_SW events. What
> would be listening for this like a pipewire?

For now this is going to be used by the usb-audio driver which contains a
quirk [1] creating the jack controls for headphone and headset mic,
respectively.  This will further setup an input handler for each of them in
order to intercept the related hotplug events.

But it can be also used directly from ALSA/pipewire, e.g. for monitoring,
hence it think it's best to keep it as an audio dedicated input device.

Regards,
Cristian

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/sound/usb/mixer_quirks.c#n540