[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7e148282f683f8e0e00a1ad29ada8319ee9e24f4.camel@mediatek.com>
Date: Tue, 22 Jul 2025 08:11:20 +0000
From: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
George Sun (孙林) <George.Sun@...iatek.com>,
Tiffany Lin (林慧珊) <tiffany.lin@...iatek.com>,
"andrzejtp2010@...il.com" <andrzejtp2010@...il.com>, "nhebert@...omium.org"
<nhebert@...omium.org>, "linux-media@...r.kernel.org"
<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "mchehab@...nel.org" <mchehab@...nel.org>,
"hverkuil@...all.nl" <hverkuil@...all.nl>, "nicolas.dufresne@...labora.com"
<nicolas.dufresne@...labora.com>,
Yunfei Dong (董云飞) <Yunfei.Dong@...iatek.com>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
Irui Wang (王瑞) <Irui.Wang@...iatek.com>,
"robh@...nel.org" <robh@...nel.org>, "sebastian.fricke@...labora.com"
<sebastian.fricke@...labora.com>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
<matthias.bgg@...il.com>, "christophe.jaillet@...adoo.fr"
<christophe.jaillet@...adoo.fr>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"arnd@...db.de" <arnd@...db.de>,
Andrew-CT Chen (陳智迪)
<Andrew-CT.Chen@...iatek.com>, AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>, "neil.armstrong@...aro.org"
<neil.armstrong@...aro.org>
Subject: Re: [PATCH v1 1/8] dt-bindings: media: mediatek: decoder: Add MT8189
mediatek,vcodec-decoder
On Tue, 2025-07-22 at 09:25 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
> > Add compatible for video decoder on MT8189 platform, which is a
> > pure single core architecture.
>
> Looks compatible with existing ones and nothing in commit msg
> explains
> why it was not made compatible. Describe the hardware, say something
> useful to avoid such questions.
>
> Best regards,
> Krzysztof
>
Dear Krzysztof,
There are two reasons for adding a new compatible string to MT8189:
On the one hand, MT8189 is a pure single-core hardware chip, so the
of_device_id data is different;
On the other hand, the correct chip name can be set through the
compatible strings;
The above two reasons are reflected in the following patch:
https://patchwork.linuxtv.org/project/linux-media/patch/20250721105520.5625-3-kyrie.wu@mediatek.com/
Thanks.
Regards,
Kyrie.
Powered by blists - more mailing lists