Message-ID: <49eeff09-993f-42a0-8e3b-b3f95b41dbcf@kernel.org>
Date: Tue, 22 Jul 2025 10:26:43 +0200
From: Daniel Gomez <da.gomez@...nel.org>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Vlastimil Babka <vbabka@...e.cz>, Daniel Gomez <da.gomez@...sung.com>,
 Matthias Maennich <maennich@...gle.com>, Jonathan Corbet <corbet@....net>,
 Luis Chamberlain <mcgrof@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>,
 Sami Tolvanen <samitolvanen@...gle.com>,
 Masahiro Yamada <masahiroy@...nel.org>, Nathan Chancellor
 <nathan@...nel.org>, Nicolas Schier <nicolas.schier@...ux.dev>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>
Cc: Christoph Hellwig <hch@...radead.org>,
 Peter Zijlstra <peterz@...radead.org>, David Hildenbrand <david@...hat.com>,
 Shivank Garg <shivankg@....com>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
 linux-kbuild@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3] module: Rename EXPORT_SYMBOL_GPL_FOR_MODULES to
 EXPORT_SYMBOL_FOR_MODULES

On 21/07/2025 12.40, Vlastimil Babka wrote:
> On 7/15/25 20:58, Daniel Gomez wrote:
>> On 15/07/2025 10.43, Vlastimil Babka wrote:
>>> Christoph suggested that the explicit _GPL_ can be dropped from the
>>> module namespace export macro, as it's intended for in-tree modules
>>> only. It would be possible to restrict it technically, but it was
>>> pointed out [2] that some cases of using an out-of-tree build of an
>>> in-tree module with the same name are legitimate. But in that case those
>>> also have to be GPL anyway so it's unnecessary to spell it out in the
>>> macro name.
>>>
>>> Link: https://lore.kernel.org/all/aFleJN_fE-RbSoFD@infradead.org/ [1]
>>> Link: https://lore.kernel.org/all/CAK7LNATRkZHwJGpojCnvdiaoDnP%2BaeUXgdey5sb_8muzdWTMkA@mail.gmail.com/ [2]
>>> Suggested-by: Christoph Hellwig <hch@...radead.org>
>>> Reviewed-by: Shivank Garg <shivankg@....com>
>>> Acked-by: David Hildenbrand <david@...hat.com>
>>> Acked-by: Nicolas Schier <n.schier@....de>
>>> Reviewed-by: Daniel Gomez <da.gomez@...sung.com>
>>> Reviewed-by: Christian Brauner <brauner@...nel.org>
>>> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
>>> ---
>>> Daniel, please clarify if you'll take this via module tree or Christian
>>> can take it via vfs tree?
>>
>> Patch 707f853d7fa3 ("module: Provide EXPORT_SYMBOL_GPL_FOR_MODULES() helper")
>> from Peter was merged through Masahiro in v6.16-rc1. Since this is a related
>> fix/rename/cleanup, it'd make sense for it to go through his kbuild tree as
>> well. Masahiro, please let me know if you'd prefer otherwise. If not, I'll queue
>> it up in the modules tree.
> 
> Maybe with no reply, you can queue it then?

+ Jiri, Stephen and Greg, added to the To: list.

EXPORT_SYMBOL_GPL_FOR_MODULES macro was merged [1] through Masahiro's
pull request in v6.16-rc1. This patch from Vlastimil renames the macro to
EXPORT_SYMBOL_FOR_MODULES. This means Jiri's patch b20d6576cdb3 "serial: 8250:
export RSA functions" will need to be updated accordingly. I'd like like to
know how you prefer to proceed, since it was requested to have this merged as a
fix before Linus releases a new kernel with the former name.

Link: https://lore.kernel.org/all/CAK7LNAQunzxOHR+vMZLf8kqxyRtLx-Z2G2VZquJmndrT9TZjiQ@mail.gmail.com/ [1]


Masahiro, just a heads-up that I plan to merge this through the linux-modules
tree unless you advise otherwise.

Powered by blists - more mailing lists