linux-kernel - Re: [PATCH 1/2] vt: keyboard: Don't process Unicode characters in K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2419b7f3-43d7-42da-a1b7-693631311707@kernel.org>
Date: Tue, 22 Jul 2025 11:06:36 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Myrrh Periwinkle <myrrhperiwinkle@...labs.xyz>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arthur Taylor <art@...ed.ca>
Cc: Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] vt: keyboard: Don't process Unicode characters in
 K_OFF mode

On 02. 07. 25, 16:17, Myrrh Periwinkle wrote:
> We don't process Unicode characters if the virtual terminal is in raw
> mode, so there's no reason why we shouldn't do the same for K_OFF
> (especially since people would expect K_OFF to actually turn off all VT
> key processing).

AFAICT

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> Fixes: 9fc3de9c8356 ("vt: Add virtual console keyboard mode OFF")
> Signed-off-by: Myrrh Periwinkle <myrrhperiwinkle@...labs.xyz>
> Cc: stable@...r.kernel.org
> ---
>   drivers/tty/vt/keyboard.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
> index dc585079c2fb8c92d37284701f15905a24161768..ee1d9c448c7ebf2f1456f6bd18e55a9681b036c2 100644
> --- a/drivers/tty/vt/keyboard.c
> +++ b/drivers/tty/vt/keyboard.c
> @@ -1487,7 +1487,7 @@ static void kbd_keycode(unsigned int keycode, int down, bool hw_raw)
>   		rc = atomic_notifier_call_chain(&keyboard_notifier_list,
>   						KBD_UNICODE, &param);
>   		if (rc != NOTIFY_STOP)
> -			if (down && !raw_mode)
> +			if (down && !(raw_mode || kbd->kbdmode == VC_OFF))
>   				k_unicode(vc, keysym, !down);
>   		return;
>   	}
> 


-- 
js
suse labs