linux-kernel - Re: [PATCH RFT v3 3/3] ufs: core: delegate the interrupt service routine to a threaded irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6573ba6fcb43f0c41239be728905fa2e936961e.camel@linaro.org>
Date: Tue, 22 Jul 2025 10:22:23 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Bart Van Assche <bvanassche@....org>, Neil Armstrong	
 <neil.armstrong@...aro.org>, Alim Akhtar <alim.akhtar@...sung.com>, Avri
 Altman	 <avri.altman@....com>, "James E.J. Bottomley"	
 <James.Bottomley@...senPartnership.com>, "Martin K. Petersen"	
 <martin.petersen@...cle.com>
Cc: Manivannan Sadhasivam <mani@...nel.org>, linux-arm-msm@...r.kernel.org, 
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Peter Griffin
	 <peter.griffin@...aro.org>, Will McVicker <willmcvicker@...gle.com>, 
	kernel-team@...roid.com, Tudor Ambarus <tudor.ambarus@...aro.org>
Subject: Re: [PATCH RFT v3 3/3] ufs: core: delegate the interrupt service
 routine to a threaded irq handler

On Mon, 2025-07-21 at 08:28 -0700, Bart Van Assche wrote:
> On 7/21/25 5:04 AM, André Draszik wrote:
> > I don't know much about UFS at this stage, but could the code simply
> > check for the controller version and revert to original behaviour
> > if < v4? Any thoughts on such a change?
> 
> I'm not sure that's the best possible solution. A more elegant solution
> could be to remove the "if (!hba->mcq_enabled || !hba->mcq_esi_enabled)"
> check, to restrict the number of commands completed by 
> ufshcd_transfer_req_compl() and only to return IRQ_WAKE_THREAD if more
> commands are pending than a certain threshold.

Thanks Bart. I'll try that instead,

Cheers,
Andre'