linux-kernel - Re: [PATCH] phy: rockchip-snps-pcie3: add support for rockchip,phy-ref-use-pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aH-FXrb-qvF3ffv1@vaman>
Date: Tue, 22 Jul 2025 18:04:38 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Damien Le Moal <dlemoal@...nel.org>
Cc: Rick Wertenbroek <rick.wertenbroek@...il.com>,
	rick.wertenbroek@...g-vd.ch, alberto.dassatti@...g-vd.ch,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>, linux-phy@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: rockchip-snps-pcie3: add support for
 rockchip,phy-ref-use-pad

On 16-07-25, 08:18, Damien Le Moal wrote:
> On 7/15/25 19:58, Rick Wertenbroek wrote:

> > &pcie30phy {
> >         rockchip,rx-common-refclk-mode = <0 0 1 1>;
> >         rockchip,phy-ref-use-pad = <0 1>;
> >         clocks = <&cru PCLK_PCIE_COMBO_PIPE_PHY>, <&cru CLK_PHY0_REF_ALT_P>,
> >                          <&cru CLK_PHY0_REF_ALT_M>, <&cru CLK_PHY1_REF_ALT_P>,
> >                          <&cru CLK_PHY1_REF_ALT_M>;
> >         clock-names = "pclk", "phy0_ref_alt_p",
> >                               "phy0_ref_alt_m", "phy1_ref_alt_p",
> >                               "phy1_ref_alt_m";
> > };
> > ---
> > 
> 
> This looks OK to me, but don't you need to also update the dt-bindings yaml to
> document this new "phy-ref-use-pad" property ?

Absolutely, without update to binding this is a no-go

-- 
~Vinod