linux-kernel - Re: [PATCH v2 2/2] ASoC: codecs: wsa883x: Handle shared reset GPIO for WSA883x speakers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ba94864-769c-4a73-8e70-a3904280317f@kernel.org>
Date: Tue, 22 Jul 2025 14:38:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>
Cc: Srinivas Kandagatla <srini@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Philipp Zabel <p.zabel@...gutronix.de>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, linux-arm-msm@...r.kernel.org, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org, quic_pkumpatl@...cinc.com,
 kernel@....qualcomm.com
Subject: Re: [PATCH v2 2/2] ASoC: codecs: wsa883x: Handle shared reset GPIO
 for WSA883x speakers

On 22/07/2025 13:11, Mohammad Rafi Shaik wrote:

Again, trim the output from irrelevant parts.

> [   10.928781][   T90] Call trace:
> [   10.932024][   T90]  _regulator_put+0x50/0x60 (P)
> [   10.936877][   T90]  regulator_put+0x30/0x48
> [   10.941276][   T90]  devm_regulator_release+0x14/0x20
> [   10.946486][   T90]  release_nodes+0x60/0xfc
> [   10.950886][   T90]  devres_release_all+0x90/0xe0
> [   10.955737][   T90]  device_unbind_cleanup+0x18/0x60
> [   10.960846][   T90]  really_probe+0x210/0x2c0
> [   10.965341][   T90]  __driver_probe_device+0x78/0x120

Although wsa probe function is not here, but this feels like it deferred
or exited with failure and some cleanups were incomplete. Current code
looks correct, so I suspect that whatever you did there introduced the
errors. So bug in your code is the answer that you converted it to devm
interface. That conversion should be rather separate patch.

Best regards,
Krzysztof