[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5051937.31r3eYUQgx@radijator>
Date: Wed, 23 Jul 2025 16:36:33 +0200
From: Duje Mihanović <duje@...emihanovic.xyz>
To: Rob Herring <robh@...nel.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, Karel Balej <balejk@...fyz.cz>,
David Wronek <david@...nlining.org>, linux-mmc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject:
Re: [PATCH RFC 1/2] dt-bindings: mmc: sdhci-pxa: add state_uhs pinctrl
On Monday, 21 July 2025 16:35:41 Central European Summer Time Rob Herring
wrote:
> On Fri, Jul 18, 2025 at 11:12:38PM +0200, Duje Mihanović wrote:
> > On the pxav3 controller, increasing the drive strength of the data pins
> > might be required to maintain stability on fast bus clocks (above 100
> > MHz). Add a state_uhs pinctrl to allow this.
> >
> > The existing state_cmd_gpio pinctrl is changed to apply only on pxav1 as
> > it's unneeded on the other controllers.
> >
> > Signed-off-by: Duje Mihanović <duje@...emihanovic.xyz>
> > ---
> >
> > .../devicetree/bindings/mmc/sdhci-pxa.yaml | 45
> > +++++++++++++++++----- 1 file changed, 35 insertions(+), 10 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> > b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml index
> >
4869ddef36fd89265a1bfe96bb9663b553ac5084..7a9e2a63ac4351aea10b2763ca250ce48
> > 89df1eb 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> >
> > @@ -30,6 +30,39 @@ allOf:
> > maxItems: 1
> >
> > reg-names:
> > maxItems: 1
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: mrvl,pxav1-mmc
> > + then:
> > + properties:
> > + pinctrl-names:
> > + description:
> > + Optional for supporting PXA168 SDIO IRQ errata to switch CMD
> > pin between + SDIO CMD and GPIO mode.
> > + items:
> > + - const: default
> > + - const: state_cmd_gpio
>
> blank line
While at it, should I do the same with the properties: blocks in the existing
if: block?
Regards,
--
Duje
Powered by blists - more mailing lists